Upgrade playwright to 1.13.1 (#179)

* Upgrade playwright to 1.13.1

* Add command to install browser locally

* Update screenshots
Remove screenshot matching on completer

Author: fcollonval

command-palette/ui-tests/README.md

@@ -44,6 +44,7 @@ jupyter lab --ServerApp.token= --ServerApp.password=
 ```
 cd ui-tests
 jlpm install
+npx playwright install
 npx playwright test
 ```
 
@@ -77,6 +78,7 @@ jupyter lab --ServerApp.token= --ServerApp.password=
 ```
 cd ui-tests
 jlpm install
+npx playwright install
 npx playwright codegen localhost:8888
 ```
 
@@ -110,5 +112,6 @@ jupyter lab --ServerApp.token= --ServerApp.password=
 ```
 cd ui-tests
 jlpm install
+npx playwright install
 PWDEBUG=1 npx playwright test
 ```

command-palette/ui-tests/package.json

@@ -7,7 +7,7 @@
   "license": "BSD-3-Clause",
   "private": true,
   "devDependencies": {
-    "@playwright/test": "1.12.3",
+    "@playwright/test": "1.13.1",
     "typescript": "~4.1.3"
   }
 }

commands/ui-tests/README.md

@@ -44,6 +44,7 @@ jupyter lab --ServerApp.token= --ServerApp.password=
 ```
 cd ui-tests
 jlpm install
+npx playwright install
 npx playwright test
 ```
 
@@ -77,6 +78,7 @@ jupyter lab --ServerApp.token= --ServerApp.password=
 ```
 cd ui-tests
 jlpm install
+npx playwright install
 npx playwright codegen localhost:8888
 ```
 
@@ -110,5 +112,6 @@ jupyter lab --ServerApp.token= --ServerApp.password=
 ```
 cd ui-tests
 jlpm install
+npx playwright install
 PWDEBUG=1 npx playwright test
 ```

commands/ui-tests/package.json

@@ -7,7 +7,7 @@
   "license": "BSD-3-Clause",
   "private": true,
   "devDependencies": {
-    "@playwright/test": "1.12.3",
+    "@playwright/test": "1.13.1",
     "typescript": "~4.1.3"
   }
 }

completer/ui-tests/README.md

@@ -44,6 +44,7 @@ jupyter lab --ServerApp.token= --ServerApp.password=
 ```
 cd ui-tests
 jlpm install
+npx playwright install
 npx playwright test
 ```
 
@@ -77,6 +78,7 @@ jupyter lab --ServerApp.token= --ServerApp.password=
 ```
 cd ui-tests
 jlpm install
+npx playwright install
 npx playwright codegen localhost:8888
 ```
 
@@ -110,5 +112,6 @@ jupyter lab --ServerApp.token= --ServerApp.password=
 ```
 cd ui-tests
 jlpm install
+npx playwright install
 PWDEBUG=1 npx playwright test
 ```

completer/ui-tests/package.json

@@ -7,7 +7,7 @@
   "license": "BSD-3-Clause",
   "private": true,
   "devDependencies": {
-    "@playwright/test": "1.12.3",
+    "@playwright/test": "1.13.1",
     "typescript": "~4.1.3"
   }
 }

completer/ui-tests/tests/completer.spec.ts

@@ -51,14 +51,13 @@ test('should open a notebook and use the completer', async ({ page }) => {
     }
   }
 
-  // Increase tolerance as the cursor may or may not be captured
-  //  - the threshold is low enough to check the completion pop-up is missing
-  expect(
-    await (await page.$('.jp-Notebook.jp-NotebookPanel-notebook')).screenshot()
-  ).toMatchSnapshot('completer-example.png', { threshold: 0.2 });
-
   // Click on suggestions
-  await suggestions.click();
+  await Promise.all([
+    page.waitForSelector('code:has-text("yMagic")', { state: 'hidden' }),
+    suggestions.click(),
+  ]);
 
-  expect(await page.waitForSelector('text=yMagic')).toBeTruthy();
+  expect(
+    await page.waitForSelector('text=yMagic', { state: 'visible' })
+  ).toBeTruthy();
 });

completer/ui-tests/tests/completer.spec.ts-snapshots/completer-example-chromium-linux.png

@@ -44,6 +44,7 @@ jupyter lab --ServerApp.token= --ServerApp.password=
 ```
 cd ui-tests
 jlpm install
+npx playwright install
 npx playwright test
 ```
 
@@ -77,6 +78,7 @@ jupyter lab --ServerApp.token= --ServerApp.password=
 ```
 cd ui-tests
 jlpm install
+npx playwright install
 npx playwright codegen localhost:8888
 ```
 
@@ -110,5 +112,6 @@ jupyter lab --ServerApp.token= --ServerApp.password=
 ```
 cd ui-tests
 jlpm install
+npx playwright install
 PWDEBUG=1 npx playwright test
 ```