Skip to content

Commit c0281bc

Browse files
authored
Merge pull request #184 from krassowski/patch-1
Update documentation excerpt
2 parents dcb1fa6 + fcc90b3 commit c0281bc

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

signals/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,8 @@ It registers the `_logMessage` function which is triggered when the signal is em
154154
155155
From the official [JupyterLab Documentation](https://jupyterlab.readthedocs.io/en/stable/developer/patterns.html#signals):
156156
157-
> Wherever possible as signal connection should be made with the pattern `.connect(this._onFoo, this)`.
158-
> Providing the `this` context enables the connection to be properly cleared by `clearSignalData(this)`.
157+
> Wherever possible a signal connection should be made with the pattern `.connect(this._onFoo, this)`.
158+
> Providing the `this` context enables the connection to be properly cleared by `Signal.clearData(this)`.
159159
> Using a private method avoids allocating a closure for each connection.
160160
161161
The `_logMessage` function receives as parameters the emitter (of type `ButtonWidget`)

0 commit comments

Comments
 (0)