Skip to content

Commit e5b003d

Browse files
committed
More fix
1 parent 58715ef commit e5b003d

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

context-menu/ui-tests/tests/context-menu.spec.ts

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,14 @@ test('should have new context menu for example files', async ({ page }) => {
3535
await page.press('input.jp-DirListing-editor', 'Enter');
3636

3737
// Wait for the data attribute to be set
38-
let type = '';
39-
do {
40-
type = await page.getAttribute(
41-
'[aria-label="File Browser Section"] >> text=test.example',
42-
'data-file-type'
43-
);
44-
} while (!type);
38+
let resolveImmediate;
39+
const waitForImmediate = new Promise((resolve) => {
40+
resolveImmediate = resolve;
41+
});
42+
setImmediate(() => {
43+
resolveImmediate();
44+
});
45+
await waitForImmediate;
4546

4647
// Click [aria-label="File Browser Section"] >> text=test.example
4748
await page.click('[aria-label="File Browser Section"] >> text=test.example', {
-6.45 KB
Loading

launcher/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ dependencies to JupyterLab features.
1010
> Credit: This example is copied from Jeremy Tuloup [Python file extension](https://github.com/jtpio/jupyterlab-python-file).
1111
1212
This example allows to create an empty Python file. To do so,
13-
your extension will use two commands defined by the [documents manager](https://github.com/jupyterlab/jupyterlab/blob/master/packages/docmanager-extension/src/index.ts#L53-L86) of JupyterLab:
13+
your extension will use two commands defined by the [documents manager](https://github.com/jupyterlab/jupyterlab/blob/master/packages/docmanager-extension/src/index.tsx#L52-L82) of JupyterLab:
1414

1515
- `'docmanager:new-untitled'`: Create new untitled document
1616
- `'docmanager:open'`: Open a document

0 commit comments

Comments
 (0)