Skip to content

Commit ea78b87

Browse files
author
Steven Silvester
committed
update readmes
1 parent 697ad67 commit ea78b87

File tree

3 files changed

+9
-12
lines changed

3 files changed

+9
-12
lines changed

advanced/server-extension/README.md

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -501,7 +501,7 @@ import os
501501

502502
from jupyter_packaging import (
503503
create_cmdclass, install_npm, ensure_targets,
504-
combine_commands, ensure_python, get_version,
504+
combine_commands, get_version,
505505
)
506506
import setuptools
507507

@@ -510,9 +510,6 @@ HERE = os.path.abspath(os.path.dirname(__file__))
510510
# The name of the project
511511
name="jlab_ext_example"
512512

513-
# Ensure a valid python version
514-
ensure_python(">=3.6")
515-
516513
# Get our version
517514
version = get_version(os.path.join(name, "_version.py"))
518515

@@ -562,10 +559,11 @@ setup_args = dict(
562559
cmdclass= cmdclass,
563560
packages=setuptools.find_packages(),
564561
install_requires=[
565-
"jupyterlab~=3.0.0b3",
562+
"jupyterlab~=3.0.0b4",
566563
],
567564
zip_safe=False,
568565
include_package_data=True,
566+
python_requires=">=3.6",
569567
license="BSD-3-Clause",
570568
platforms="Linux, Mac OS X, Windows",
571569
keywords=["Jupyter", "JupyterLab"],
@@ -584,7 +582,6 @@ setup_args = dict(
584582
if __name__ == "__main__":
585583
setuptools.setup(**setup_args)
586584

587-
588585
```
589586
590587
But in this case, it is a bit more complicated to build the frontend extension and ship it
@@ -593,7 +590,7 @@ the frontend NPM package needs to be built and inserted in the Python package. T
593590
done using a special `cmdclass`:
594591
595592
```py
596-
# setup.py#L45-L53
593+
# setup.py#L42-L50
597594

598595
cmdclass = create_cmdclass("jsdeps",
599596
package_data_spec=package_data_spec,
@@ -609,15 +606,15 @@ cmdclass["jsdeps"] = combine_commands(
609606
Basically it will build the frontend NPM package:
610607
611608
```py
612-
# setup.py#L51-L51
609+
# setup.py#L48-L48
613610

614611
install_npm(HERE, build_cmd="build:all", npm=["jlpm"]),
615612
```
616613
617614
It will ensure one of the generated JS files is `lib/jlabextexample.js`:
618615
619616
```py
620-
# setup.py#L26-L29
617+
# setup.py#L23-L26
621618

622619
jstargets = [
623620
os.path.join(HERE, "lib", "index.js"),

basics/hello-world/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ package is declared in the file `package.json`:
9494
// package.json#L44-L46
9595

9696
"dependencies": {
97-
"@jupyterlab/application": "~3.0.0-beta.3"
97+
"@jupyterlab/application": "~3.0.0-beta.4"
9898
},
9999
```
100100

main-menu/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,8 @@ After the execution of that command, `package.json` should list them in the
8888
// package.json#L44-L48
8989

9090
"dependencies": {
91-
"@jupyterlab/application": "~3.0.0-beta.3",
92-
"@jupyterlab/mainmenu": "~3.0.0-beta.3",
91+
"@jupyterlab/application": "~3.0.0-beta.4",
92+
"@jupyterlab/mainmenu": "~3.0.0-beta.4",
9393
"@lumino/widgets": "^1.14.0"
9494
},
9595
```

0 commit comments

Comments
 (0)