Skip to content

Commit 28eac5e

Browse files
committed
fix unit test by declaring MockProvider.raise_exc
1 parent 4e02a05 commit 28eac5e

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

packages/jupyter-ai/jupyter_ai/tests/completions/test_handlers.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,15 @@ class MockProvider(BaseProvider, FakeListLLM):
2121
name = "My Provider"
2222
model_id_key = "model"
2323
models = ["model"]
24+
raise_exc: bool = False
2425

2526
def __init__(self, **kwargs):
2627
if "responses" not in kwargs:
2728
kwargs["responses"] = ["Test response"]
2829
super().__init__(**kwargs)
2930

3031
async def _acall(self, *args, **kwargs):
31-
if hasattr(self, "raise_exc") and self.raise_exc:
32+
if self.raise_exc:
3233
raise Exception("Test exception")
3334
else:
3435
return super()._call(*args, **kwargs)
@@ -209,5 +210,5 @@ async def test_handle_request_with_error(inline_handler):
209210
)
210211
await inline_handler.on_message(json.dumps(dict(dummy_request)))
211212
await inline_handler.tasks[0]
212-
error = inline_handler.messages[-1].dict().get("error", None)
213+
error = inline_handler.messages[-1].model_dump().get("error", None)
213214
assert error is not None

0 commit comments

Comments
 (0)