Skip to content

Commit 4a0bcb1

Browse files
committed
prefer .model_dump_json() over .json()
Addresses a Pydantic v2 deprecation warning, as `BaseModel.json()` is now deprecated in favor of `BaseModel.model_dump_json()`.
1 parent b246404 commit 4a0bcb1

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

packages/jupyter-ai/jupyter_ai/chat_handlers/learn.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,7 @@ def save(self):
360360

361361
def save_metadata(self):
362362
with open(METADATA_SAVE_PATH, "w") as f:
363-
f.write(self.metadata.json())
363+
f.write(self.metadata.model_dump_json())
364364

365365
def load_metadata(self):
366366
if not os.path.exists(METADATA_SAVE_PATH):

packages/jupyter-ai/jupyter_ai/handlers.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ async def get(self):
6666
history = ChatHistory(
6767
messages=self.chat_history, pending_messages=self.pending_messages
6868
)
69-
self.finish(history.json())
69+
self.finish(history.model_dump_json())
7070

7171

7272
class RootChatHandler(JupyterHandler, websocket.WebSocketHandler):
@@ -494,7 +494,7 @@ def get(self):
494494

495495
# Finally, yield response.
496496
response = ListProvidersResponse(providers=providers)
497-
self.finish(response.json())
497+
self.finish(response.model_dump_json())
498498

499499

500500
class EmbeddingsModelProviderHandler(ProviderHandler):
@@ -517,7 +517,7 @@ def get(self):
517517
providers = sorted(providers, key=lambda p: p.name)
518518

519519
response = ListProvidersResponse(providers=providers)
520-
self.finish(response.json())
520+
self.finish(response.model_dump_json())
521521

522522

523523
class GlobalConfigHandler(BaseAPIHandler):
@@ -535,7 +535,7 @@ def get(self):
535535
if not config:
536536
raise HTTPError(500, "No config found.")
537537

538-
self.finish(config.json())
538+
self.finish(config.model_dump_json())
539539

540540
@web.authenticated
541541
def post(self):
@@ -587,7 +587,7 @@ def get(self):
587587

588588
# if no selected LLM, return an empty response
589589
if not self.config_manager.lm_provider:
590-
self.finish(response.json())
590+
self.finish(response.model_dump_json())
591591
return
592592

593593
for id, chat_handler in self.chat_handlers.items():
@@ -616,7 +616,7 @@ def get(self):
616616

617617
# sort slash commands by slash id and deliver the response
618618
response.slash_commands.sort(key=lambda sc: sc.slash_id)
619-
self.finish(response.json())
619+
self.finish(response.model_dump_json())
620620

621621

622622
class AutocompleteOptionsHandler(BaseAPIHandler):
@@ -640,7 +640,7 @@ def get(self):
640640

641641
# if no selected LLM, return an empty response
642642
if not self.config_manager.lm_provider:
643-
self.finish(response.json())
643+
self.finish(response.model_dump_json())
644644
return
645645

646646
partial_cmd = self.get_query_argument("partialCommand", None)
@@ -666,7 +666,7 @@ def get(self):
666666
response.options = (
667667
self._get_slash_command_options() + self._get_context_provider_options()
668668
)
669-
self.finish(response.json())
669+
self.finish(response.model_dump_json())
670670

671671
def _get_slash_command_options(self) -> List[ListOptionsEntry]:
672672
options = []

0 commit comments

Comments
 (0)