Add ignore globs for hidden files in CM config (#1396)

* Add additional glob pattern to hide files.

* Commit changes and precommit fixes.

Author: ellisonbg

packages/jupyter-ai/jupyter_ai/extension.py

@@ -441,5 +441,21 @@ def _link_jupyter_server_extension(self, server_app: ServerApp):
         """Setup custom config needed by this extension."""
         c = Config()
         c.ContentsManager.allow_hidden = True
+        c.ContentsManager.hide_globs = [
+            "__pycache__",  # Python bytecode cache directories
+            "*.pyc",  # Compiled Python files
+            "*.pyo",  # Optimized Python files
+            ".DS_Store",  # macOS system files
+            "*~",  # Editor backup files
+            ".ipynb_checkpoints",  # Jupyter notebook checkpoint files
+            ".git",  # Git version control directory
+            ".venv",  # Python virtual environment directory
+            "venv",  # Python virtual environment directory
+            ".env",  # Environment variable files
+            "node_modules",  # Node.js dependencies directory
+            ".pytest_cache",  # PyTest cache directory
+            ".mypy_cache",  # MyPy type checker cache directory
+            "*.egg-info",  # Python package metadata directories
+        ]
         server_app.update_config(c)
         super()._link_jupyter_server_extension(server_app)

packages/jupyter-ai/jupyter_ai/personas/persona_manager.py

@@ -9,7 +9,7 @@
 from logging import Logger
 from pathlib import Path
 from time import time_ns
-from typing import TYPE_CHECKING, Any, ClassVar
+from typing import TYPE_CHECKING, Any
 
 from importlib_metadata import entry_points
 from jupyterlab_chat.models import Message
@@ -60,7 +60,6 @@ class PersonaManager(LoggingConfigurable):
     _personas: dict[str, BasePersona]
     file_id: str
 
-
     def __init__(
         self,
         *args,
@@ -319,7 +318,7 @@ def load_from_dir(root_dir: str, log: Logger) -> list[type[BasePersona]]:
     `PersonaManager`.
 
     Scans the root_dir for .py files containing `persona` in their name that do
-    _not_ start with a single `_` (i.e. private modules are skipped). Then, it 
+    _not_ start with a single `_` (i.e. private modules are skipped). Then, it
     dynamically imports them, and extracts any class declarations that are
     subclasses of `BasePersona`.
 
@@ -343,22 +342,26 @@ def load_from_dir(root_dir: str, log: Logger) -> list[type[BasePersona]]:
         py_files = []
         for f in all_py_files:
             fname_lower = Path(f).stem.lower()
-            if "persona" in fname_lower and not (fname_lower.startswith("_") or fname_lower.startswith(".")):
+            if "persona" in fname_lower and not (
+                fname_lower.startswith("_") or fname_lower.startswith(".")
+            ):
                 py_files.append(f)
 
     except Exception as e:
         # On exception with glob operation, return empty list
-        log.error(f"{type(e).__name__} occurred while searching for Python files in {root_dir}")
+        log.error(
+            f"{type(e).__name__} occurred while searching for Python files in {root_dir}"
+        )
         return persona_classes
 
     if py_files:
         log.info(f"Found files from {root_dir}: {[Path(f).name for f in py_files]}")
-    
+
     # Temporarily add root_dir to sys.path for imports
     root_dir_in_path = root_dir in sys.path
     if not root_dir_in_path:
         sys.path.insert(0, root_dir)
-    
+
     try:
         # For each .py file, dynamically import the module and extract all
         # BasePersona subclasses.
@@ -386,14 +389,15 @@ def load_from_dir(root_dir: str, log: Logger) -> list[type[BasePersona]]:
                         log.info(f"Found persona class '{obj.__name__}' in '{py_file}'")
                         persona_classes.append(obj)
 
-            except Exception as e:
+            except Exception:
                 # On exception, log error and continue to next file
-                log.exception(f"Unable to load persona classes from '{py_file}', exception details printed below.")
+                log.exception(
+                    f"Unable to load persona classes from '{py_file}', exception details printed below."
+                )
                 continue
     finally:
         # Remove root_dir from sys.path if we added it
         if not root_dir_in_path and root_dir in sys.path:
             sys.path.remove(root_dir)
 
     return persona_classes
-

packages/jupyter-ai/jupyter_ai/tests/test_personas.py

@@ -31,17 +31,19 @@ def test_empty_directory_returns_empty_list(self, tmp_persona_dir, mock_logger):
         """Test that an empty directory returns an empty list of persona classes."""
         result = load_from_dir(str(tmp_persona_dir), mock_logger)
         assert result == []
-    
+
     def test_non_persona_file_returns_empty_list(self, tmp_persona_dir, mock_logger):
         """Test that a Python file without persona classes returns an empty list."""
         # Create a file that doesn't contain "persona" in the name
         non_persona_file = tmp_persona_dir / "no_personas.py"
         non_persona_file.write_text("pass")
-        
+
         result = load_from_dir(str(tmp_persona_dir), mock_logger)
         assert result == []
-    
-    def test_simple_persona_file_returns_persona_class(self, tmp_persona_dir, mock_logger):
+
+    def test_simple_persona_file_returns_persona_class(
+        self, tmp_persona_dir, mock_logger
+    ):
         """Test that a file with a BasePersona subclass returns that class."""
         # Create a simple persona file
         persona_file = tmp_persona_dir / "simple_personas.py"
@@ -52,24 +54,24 @@ class TestPersona(BasePersona):
     id = "test_persona"
     name = "Test Persona"
     description = "A simple test persona"
-    
+
     def process_message(self, message):
         pass
 """
         persona_file.write_text(persona_content)
-        
+
         result = load_from_dir(str(tmp_persona_dir), mock_logger)
-        
+
         assert len(result) == 1
         assert result[0].__name__ == "TestPersona"
         assert issubclass(result[0], BasePersona)
-    
+
     def test_bad_persona_file_returns_empty_list(self, tmp_persona_dir, mock_logger):
         """Test that a file with syntax errors returns empty list."""
         # Create a file with invalid Python code
-        bad_persona_file = tmp_persona_dir / "bad_persona.py" 
+        bad_persona_file = tmp_persona_dir / "bad_persona.py"
         bad_persona_file.write_text("1/0")
-        
+
         result = load_from_dir(str(tmp_persona_dir), mock_logger)
-        
+
         assert result == []