[v2] Inline completions websocket does not the `serverSettings` passed so sometimes it uses wrong URL

[krassowski]

Description

It accepts serverSettings here:

jupyter-ai/packages/jupyter-ai/src/completions/handler.ts

Lines 12 to 24 in 48b5c6f

	export class CompletionWebsocketHandler implements IDisposable {
	/**
	* The server settings used to make API requests.
	*/
	readonly serverSettings: ServerConnection.ISettings;
	/**
	* Create a new completion handler.
	*/
	constructor(options: AiService.IOptions = {}) {
	this.serverSettings =
	options.serverSettings ?? ServerConnection.makeSettings();
	}

But they are not passed there:

jupyter-ai/packages/jupyter-ai/src/completions/plugin.ts

Lines 61 to 76 in 48b5c6f

	activate: async (
	app: JupyterFrontEnd,
	completionManager: ICompletionProviderManager,
	languageRegistry: IEditorLanguageRegistry,
	settingRegistry: ISettingRegistry,
	statusItem: IJaiStatusItem | null
	): Promise<JaiCompletionToken> => {
	if (typeof completionManager.registerInlineProvider === 'undefined') {
	// Gracefully short-circuit on JupyterLab 4.0 and Notebook 7.0
	console.warn(
	'Inline completions are only supported in JupyterLab 4.1+ and Jupyter Notebook 7.1+'
	);
	return null;
	}
	const completionHandler = new CompletionWebsocketHandler();

Reproduce

1. Change app URL by providing a custom baseURL in page config or custom serverSettings
2. See that inline completer webscocket does not connect

Expected behavior

It connects

Context

See:

• Making it possible to swap baseURL in flight jupyterlab#17878
• Systematise how base URL is obtained to allow swapping it more easily jupyterlab#17952

[krassowski]

To fix it:

- const completionHandler = new CompletionWebsocketHandler(); 
+ const completionHandler = new CompletionWebsocketHandler({serverSettings: app.serviceManager.serverSettings});

But I do not know if 2.x is accepting patches?

[dlqqq]

@krassowski Yes, we can accept 2.x patches! I'm working on one coming up soon.

[dlqqq]

Thanks for catching this