From 7c0348248aa4a414f85a887bfde14f49f7ecdca8 Mon Sep 17 00:00:00 2001 From: "David L. Qiu" Date: Wed, 15 Jan 2025 15:09:28 -0800 Subject: [PATCH 1/3] use StrOutputParser in default chat --- packages/jupyter-ai/jupyter_ai/chat_handlers/default.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/jupyter-ai/jupyter_ai/chat_handlers/default.py b/packages/jupyter-ai/jupyter_ai/chat_handlers/default.py index e25cfd88c..f0ced25d1 100644 --- a/packages/jupyter-ai/jupyter_ai/chat_handlers/default.py +++ b/packages/jupyter-ai/jupyter_ai/chat_handlers/default.py @@ -4,6 +4,7 @@ from jupyter_ai_magics.providers import BaseProvider from jupyterlab_chat.models import Message from langchain_core.runnables.history import RunnableWithMessageHistory +from langchain_core.output_parsers import StrOutputParser from ..context_providers import ContextProviderException, find_commands from .base import BaseChatHandler, SlashCommandRoutingType @@ -36,7 +37,7 @@ def create_llm_chain( self.llm = llm self.prompt_template = prompt_template - runnable = prompt_template | llm # type:ignore + runnable = prompt_template | llm | StrOutputParser() # type:ignore if not llm.manages_history: runnable = RunnableWithMessageHistory( runnable=runnable, # type:ignore[arg-type] From 6605d0106fa62d2fe3b39f7da7865c0c48e82f77 Mon Sep 17 00:00:00 2001 From: "David L. Qiu" Date: Wed, 15 Jan 2025 15:10:26 -0800 Subject: [PATCH 2/3] encourage using StrOutputParser in docs --- docs/source/developers/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/source/developers/index.md b/docs/source/developers/index.md index 46b6c5719..465b5d1ee 100644 --- a/docs/source/developers/index.md +++ b/docs/source/developers/index.md @@ -492,7 +492,7 @@ def create_llm_chain( prompt_template = FIX_PROMPT_TEMPLATE self.prompt_template = prompt_template - runnable = prompt_template | llm # type:ignore + runnable = prompt_template | llm | StrOutputParser() # type:ignore self.llm_chain = runnable ``` From ed3bcf8bad9e2b68b28bc2eb0b6dd0ccca1b61d7 Mon Sep 17 00:00:00 2001 From: "David L. Qiu" Date: Wed, 15 Jan 2025 15:27:12 -0800 Subject: [PATCH 3/3] pre-commit --- packages/jupyter-ai/jupyter_ai/chat_handlers/default.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/jupyter-ai/jupyter_ai/chat_handlers/default.py b/packages/jupyter-ai/jupyter_ai/chat_handlers/default.py index f0ced25d1..b1206da9c 100644 --- a/packages/jupyter-ai/jupyter_ai/chat_handlers/default.py +++ b/packages/jupyter-ai/jupyter_ai/chat_handlers/default.py @@ -3,8 +3,8 @@ from jupyter_ai_magics.providers import BaseProvider from jupyterlab_chat.models import Message -from langchain_core.runnables.history import RunnableWithMessageHistory from langchain_core.output_parsers import StrOutputParser +from langchain_core.runnables.history import RunnableWithMessageHistory from ..context_providers import ContextProviderException, find_commands from .base import BaseChatHandler, SlashCommandRoutingType