-
-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Problem
Currently, jupyter-builder depends on jupyterlab to get core metadata:
jupyter-builder/jupyter_builder/core_path.py
Lines 4 to 10 in 880a31d
| from pathlib import Path | |
| def default_core_path() -> str: | |
| import jupyterlab | |
| return str(Path(jupyterlab.__file__).parent / "staging") |
I discovered this in run-time CI failure on running jlpm run build
https://github.com/Darshan808/extension-template/actions/runs/21736558199/job/62702708930?pr=1
This has been discussed on following places
#12 (comment)
#29 (comment)
Proposed Solution from suggestions above
- Create a new lightweight npm package
@jupyterlab/core-metacontaining only metadata (package.json, version info, and things we need) - Publish
@jupyterlab/core-metafor all JupyterLab releases (retroactively and for future releases) - Update
jupyter-builderto read metadata fromnode_modules/@jupyterlab/core-meta/instead of importingjupyterlab
Benefits
- Extensions can build without installing full JupyterLab package
- Eliminates circular dependency
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working
Type
Projects
Status
Todo