[FIX] Message toolbar buttons overlaps with text.#378
[FIX] Message toolbar buttons overlaps with text.#378nakul-py wants to merge 6 commits intojupyterlab:mainfrom
Conversation
|
Don't know if we want a grey background on all messages.
@andrii-i any opinion on it ? |
There was a problem hiding this comment.
@nakul-py thank you for working on this.
@nakul-py @brichet I think it's a clear improvement vs current state where icon has no background and still overlaps with text. As I mention in #375, ideally we'd position the toolbar so it never overlaps with message text (e.g., above the message bubble or in a dedicated gutter) but If overlapping is unavoidable, giving the toolbar a solid/opaque background so buttons are clearly distinguishable from the text beneath would also be an improvement.
|
@nakul-py Could you try positioning the toolbar so it never overlaps message text (e.g., above the message bubble or in a dedicated gutter) approach? As of now this PR is an improvement but we still have a button overlapping with text. Ideally we'd like to avoid it. Also note that as @brichet points out currently this PR changes background color of the messages box, we definitely would like to avoid that. |
|
I agree that this is already a good improvement, thanks @nakul-py.
I wonder where the toolbar could be positioned without taking more space or moving the messages when displayed.
I don't think this PR changes the message background. |
|
Thanks @nakul-py for updating it. But I don't have a strong opinion on it, and will be fine with any option. |
Sure i will give this a try if it does not overlaps with message time. |



Adding solid background to message toolbar buttons and change their position to bottom right corner of the message.
Screencast.From.2026-03-12.16-26-19.mp4