Skip to content

Commit 0682d45

Browse files
Use WebSocket _room_id attribute (#266)
1 parent 7a4859b commit 0682d45

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

jupyter_collaboration/handlers.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ async def open(self, room_id):
215215

216216
self._emit(LogLevel.INFO, "initialize", "New client connected.")
217217
else:
218-
if self.room.room_id != "JupyterLab:globalAwareness":
218+
if self._room_id != "JupyterLab:globalAwareness":
219219
self._emit_awareness_event(self.current_user.username, "join")
220220

221221
async def send(self, message):
@@ -296,7 +296,7 @@ def on_close(self) -> None:
296296
# keep the document for a while in case someone reconnects
297297
self.log.info("Cleaning room: %s", self._room_id)
298298
self.room.cleaner = asyncio.create_task(self._clean_room())
299-
if self.room.room_id != "JupyterLab:globalAwareness":
299+
if self._room_id != "JupyterLab:globalAwareness":
300300
self._emit_awareness_event(self.current_user.username, "leave")
301301

302302
def _emit(self, level: LogLevel, action: str | None = None, msg: str | None = None) -> None:
@@ -339,7 +339,7 @@ async def _clean_room(self) -> None:
339339

340340
async with self._room_lock(self._room_id):
341341
# Remove the room from the websocket server
342-
self.log.info("Deleting Y document from memory: %s", self.room.room_id)
342+
self.log.info("Deleting Y document from memory: %s", self._room_id)
343343
self._websocket_server.delete_room(room=self.room)
344344

345345
# Clean room

0 commit comments

Comments
 (0)