Skip to content

Commit 0a75715

Browse files
Update event schema version type (#421)
* Update event schema version type * Tweak maxDiffPixelRatio * Set maxDiffPixelRatio to 0.001 Co-authored-by: Duc Trung Le <[email protected]> * Set maxDiffPixelRatio to 0.01 --------- Co-authored-by: Duc Trung Le <[email protected]>
1 parent dcce8f5 commit 0a75715

File tree

5 files changed

+6
-4
lines changed

5 files changed

+6
-4
lines changed

projects/jupyter-server-ydoc/jupyter_server_ydoc/events/awareness.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
"$id": https://schema.jupyter.org/jupyter_collaboration/awareness/v1
22
"$schema": "http://json-schema.org/draft-07/schema"
3-
version: 1
3+
version: "1"
44
title: Collaborative awareness events
55
personal-data: true
66
description: |

projects/jupyter-server-ydoc/jupyter_server_ydoc/events/fork.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
"$id": https://schema.jupyter.org/jupyter_collaboration/fork/v1
22
"$schema": "http://json-schema.org/draft-07/schema"
3-
version: 1
3+
version: "1"
44
title: Collaborative fork events
55
personal-data: true
66
description: |

projects/jupyter-server-ydoc/jupyter_server_ydoc/events/session.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
"$id": https://schema.jupyter.org/jupyter_collaboration/session/v1
22
"$schema": "http://json-schema.org/draft-07/schema"
3-
version: 1
3+
version: "1"
44
title: Collaborative session events
55
personal-data: true
66
description: |

pyproject.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,8 @@ filterwarnings = [
106106
'ignore:Unclosed <MemoryObjectSendStream:ResourceWarning',
107107
# see https://github.com/python/cpython/issues/126259
108108
'ignore:unclosed database in <sqlite3.Connection object',
109+
# remove when this is merged: https://github.com/jupyter-server/jupyter_server/pull/1481
110+
'ignore:The `version` property of an event schema must be a string'
109111
]
110112

111113
[tool.mypy]

ui-tests/playwright.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ module.exports = {
2020
},
2121
expect: {
2222
toMatchSnapshot: {
23-
maxDiffPixelRatio: 0.0001
23+
maxDiffPixelRatio: 0.01
2424
}
2525
}
2626
};

0 commit comments

Comments
 (0)