Skip to content

Commit 2a12873

Browse files
committed
Fix for testing drive
1 parent 753487a commit 2a12873

File tree

5 files changed

+27
-41
lines changed

5 files changed

+27
-41
lines changed

packages/collaboration-extension/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
},
7272
"devDependencies": {
7373
"@jupyterlab/builder": "^4.0.5",
74-
"@types/react": "~18.0.26",
74+
"@types/react": "~18.3.1",
7575
"npm-run-all": "^4.1.5",
7676
"rimraf": "^4.1.2",
7777
"typescript": "~5.0.4"

packages/collaboration/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
"yjs": "^13.5.40"
5555
},
5656
"devDependencies": {
57-
"@types/react": "^18.0.27",
57+
"@types/react": "~18.3.1",
5858
"rimraf": "^4.1.2",
5959
"typescript": "~5.0.4"
6060
},

packages/docprovider-extension/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
},
7272
"devDependencies": {
7373
"@jupyterlab/builder": "^4.0.0",
74-
"@types/react": "~18.0.26",
74+
"@types/react": "~18.3.1",
7575
"npm-run-all": "^4.1.5",
7676
"rimraf": "^4.1.2",
7777
"typescript": "~5.0.4"

packages/docprovider/src/notebookCellExecutor.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,16 @@ export class NotebookCellServerExecutor implements INotebookCellExecutor {
9595
let documentId = `json:notebook:${fileId}`;
9696
if (!fileId) {
9797
if (
98-
this._contents.driveName(sessionContext.path) === this._drive.name
98+
// FIXME sessionContext.path seems to be local - should we by-pass this test?
99+
['', this._drive.name].includes(
100+
this._contents.driveName(
101+
sessionContext.session?.path ?? sessionContext.path
102+
)
103+
)
99104
) {
100-
const localPath = this._contents.localPath(sessionContext.path);
105+
const localPath = this._contents.localPath(
106+
sessionContext.session?.path ?? sessionContext.path
107+
);
101108
documentId =
102109
this._drive.getRoomName({
103110
localPath: localPath,

yarn.lock

Lines changed: 15 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -2100,7 +2100,7 @@ __metadata:
21002100
"@jupyterlab/translation": ^4.2.0
21012101
"@jupyterlab/ui-components": ^4.2.0
21022102
"@lumino/widgets": ^2.1.0
2103-
"@types/react": ~18.0.26
2103+
"@types/react": ~18.3.1
21042104
npm-run-all: ^4.1.5
21052105
rimraf: ^4.1.2
21062106
typescript: ~5.0.4
@@ -2124,7 +2124,7 @@ __metadata:
21242124
"@lumino/coreutils": ^2.1.0
21252125
"@lumino/virtualdom": ^2.0.0
21262126
"@lumino/widgets": ^2.1.0
2127-
"@types/react": ^18.0.27
2127+
"@types/react": ~18.3.1
21282128
react: ^18.2.0
21292129
rimraf: ^4.1.2
21302130
typescript: ~5.0.4
@@ -2141,7 +2141,7 @@ __metadata:
21412141
"@jupyter/ydoc": ^2.0.0
21422142
"@jupyterlab/application": ^4.2.0
21432143
"@jupyterlab/apputils": ^4.2.0
2144-
"@jupyterlab/builder": ^4.0.5
2144+
"@jupyterlab/builder": ^4.0.0
21452145
"@jupyterlab/docregistry": ^4.2.0
21462146
"@jupyterlab/filebrowser": ^4.2.0
21472147
"@jupyterlab/fileeditor": ^4.2.0
@@ -2150,7 +2150,7 @@ __metadata:
21502150
"@jupyterlab/settingregistry": ^4.2.0
21512151
"@jupyterlab/translation": ^4.2.0
21522152
"@lumino/commands": ^2.1.0
2153-
"@types/react": ~18.0.26
2153+
"@types/react": ~18.3.1
21542154
npm-run-all: ^4.1.5
21552155
rimraf: ^4.1.2
21562156
typescript: ~5.0.4
@@ -2165,9 +2165,13 @@ __metadata:
21652165
resolution: "@jupyter/docprovider@workspace:packages/docprovider"
21662166
dependencies:
21672167
"@jupyter/ydoc": ^2.0.0
2168-
"@jupyterlab/coreutils": ^6.0.5
2169-
"@jupyterlab/services": ^7.0.5
2170-
"@jupyterlab/testing": ^4.0.5
2168+
"@jupyterlab/apputils": ^4.2.0
2169+
"@jupyterlab/cells": ^4.2.0
2170+
"@jupyterlab/coreutils": ^6.2.0
2171+
"@jupyterlab/notebook": ^4.2.0
2172+
"@jupyterlab/services": ^7.2.0
2173+
"@jupyterlab/testing": ^4.0.0
2174+
"@jupyterlab/translation": ^4.2.0
21712175
"@lumino/coreutils": ^2.1.0
21722176
"@lumino/disposable": ^2.1.0
21732177
"@lumino/signaling": ^2.1.0
@@ -2312,7 +2316,7 @@ __metadata:
23122316
languageName: node
23132317
linkType: hard
23142318

2315-
"@jupyterlab/builder@npm:^4.0.5":
2319+
"@jupyterlab/builder@npm:^4.0.0, @jupyterlab/builder@npm:^4.0.5":
23162320
version: 4.2.0
23172321
resolution: "@jupyterlab/builder@npm:4.2.0"
23182322
dependencies:
@@ -2814,7 +2818,7 @@ __metadata:
28142818
languageName: node
28152819
linkType: hard
28162820

2817-
"@jupyterlab/testing@npm:^4.0.5":
2821+
"@jupyterlab/testing@npm:^4.0.0":
28182822
version: 4.2.0
28192823
resolution: "@jupyterlab/testing@npm:4.2.0"
28202824
dependencies:
@@ -4184,7 +4188,7 @@ __metadata:
41844188
languageName: node
41854189
linkType: hard
41864190

4187-
"@types/react@npm:^18.0.26, @types/react@npm:^18.0.27":
4191+
"@types/react@npm:^18.0.26, @types/react@npm:~18.3.1":
41884192
version: 18.3.1
41894193
resolution: "@types/react@npm:18.3.1"
41904194
dependencies:
@@ -4194,24 +4198,6 @@ __metadata:
41944198
languageName: node
41954199
linkType: hard
41964200

4197-
"@types/react@npm:~18.0.26":
4198-
version: 18.0.38
4199-
resolution: "@types/react@npm:18.0.38"
4200-
dependencies:
4201-
"@types/prop-types": "*"
4202-
"@types/scheduler": "*"
4203-
csstype: ^3.0.2
4204-
checksum: 34481c79f4f7ea2aefbaa45281319dc183200230d932d968463eba1643bd3635073d0a17c5c613150a69e36ca18b811ecffafea6384fa3dff3b5203866339d69
4205-
languageName: node
4206-
linkType: hard
4207-
4208-
"@types/scheduler@npm:*":
4209-
version: 0.23.0
4210-
resolution: "@types/scheduler@npm:0.23.0"
4211-
checksum: 874d753aa65c17760dfc460a91e6df24009bde37bfd427a031577b30262f7770c1b8f71a21366c7dbc76111967384cf4090a31d65315155180ef14bd7acccb32
4212-
languageName: node
4213-
linkType: hard
4214-
42154201
"@types/semver@npm:^7.3.12":
42164202
version: 7.5.8
42174203
resolution: "@types/semver@npm:7.5.8"
@@ -12355,14 +12341,7 @@ __metadata:
1235512341
languageName: node
1235612342
linkType: hard
1235712343

12358-
"safe-buffer@npm:^5.1.0":
12359-
version: 5.2.1
12360-
resolution: "safe-buffer@npm:5.2.1"
12361-
checksum: b99c4b41fdd67a6aaf280fcd05e9ffb0813654894223afb78a31f14a19ad220bba8aba1cb14eddce1fcfb037155fe6de4e861784eb434f7d11ed58d1e70dd491
12362-
languageName: node
12363-
linkType: hard
12364-
12365-
"safe-buffer@npm:~5.1.0, safe-buffer@npm:~5.1.1":
12344+
"safe-buffer@npm:^5.1.0, safe-buffer@npm:~5.1.0, safe-buffer@npm:~5.1.1":
1236612345
version: 5.1.2
1236712346
resolution: "safe-buffer@npm:5.1.2"
1236812347
checksum: f2f1f7943ca44a594893a852894055cf619c1fbcb611237fc39e461ae751187e7baf4dc391a72125e0ac4fb2d8c5c0b3c71529622e6a58f46b960211e704903c

0 commit comments

Comments
 (0)