Reset dirty state only when the file is saved (#472)

Darshan808 · web-flow · commit 70d02049aa2f · 2025-04-11T11:02:40.000+01:00
diff --git a/projects/jupyter-server-ydoc/jupyter_server_ydoc/rooms.py b/projects/jupyter-server-ydoc/jupyter_server_ydoc/rooms.py
@@ -285,9 +285,9 @@ async def _maybe_save_document(self, saving_document: asyncio.Task | None) -> No
                     "content": self._document.source,
                 }
             )
-            async with self._update_lock:
-                self._document.dirty = False
-                if saved_model:
+            if saved_model:
+                async with self._update_lock:
+                    self._document.dirty = False
                     self._document.hash = saved_model["hash"]
 
             self._emit(LogLevel.INFO, "save", "Content saved.")

Original file line number	Diff line number	Diff line change
`@@ -285,9 +285,9 @@ async def _maybe_save_document(self, saving_document: asyncio.Task \| None) -> No`
`285`	`285`	`"content": self._document.source,`
`286`	`286`	`}`
`287`	`287`	`)`
`288`		`- async with self._update_lock:`
`289`		`- self._document.dirty = False`
`290`		`- if saved_model:`
	`288`	`+ if saved_model:`
	`289`	`+ async with self._update_lock:`
	`290`	`+ self._document.dirty = False`
`291`	`291`	`self._document.hash = saved_model["hash"]`
`292`	`292`
`293`	`293`	`self._emit(LogLevel.INFO, "save", "Content saved.")`