Skip saving non-writable files (#457)

* skip-saving-unwritable-files

* fix-test

* pre-commit fix

* Update projects/jupyter-server-ydoc/jupyter_server_ydoc/loaders.py

---------

Co-authored-by: David Brochart <[email protected]>

Author: Darshan808

projects/jupyter-server-ydoc/jupyter_server_ydoc/loaders.py

@@ -153,6 +153,9 @@ async def maybe_save_content(self, model: dict[str, Any]) -> dict[str, Any] | No
                     path, format=model["format"], type=model["type"], content=False
                 )
             )
+            # Skip saving if file is not writable
+            if not m["writable"]:
+                return None
 
             if self.last_modified == m["last_modified"]:
                 self._log.info("Saving file: %s", path)

projects/jupyter-server-ydoc/jupyter_server_ydoc/pytest_plugin.py

@@ -271,13 +271,16 @@ def _inner(
         last_modified: datetime | None = None,
         save_delay: float | None = None,
         store: SQLiteYStore | None = None,
+        writable: bool = False,
     ) -> tuple[FakeContentsManager, FileLoader, DocumentRoom]:
         paths = {id: path}
 
         if last_modified is None:
-            cm = FakeContentsManager({"content": content})
+            cm = FakeContentsManager({"content": content, "writable": writable})
         else:
-            cm = FakeContentsManager({"last_modified": datetime.now(), "content": content})
+            cm = FakeContentsManager(
+                {"last_modified": datetime.now(), "content": content, "writable": writable}
+            )
 
         loader = FileLoader(
             id,

tests/test_rooms.py

@@ -51,7 +51,9 @@ async def test_defined_save_delay_should_save_content_after_document_change(
     rtc_create_mock_document_room,
 ):
     content = "test"
-    cm, _, room = rtc_create_mock_document_room("test-id", "test.txt", content, save_delay=0.01)
+    cm, _, room = rtc_create_mock_document_room(
+        "test-id", "test.txt", content, save_delay=0.01, writable=True
+    )
 
     await room.initialize()
     room._document.source = "Test 2"