Fix mypy (#358)

* Remove type ignore that make mypy fails

* Fix the increment version

* Revert "Fix the increment version"

This reverts commit c24d5ca.

* Revert "Remove type ignore that make mypy fails"

This reverts commit 2af5bc8.

* Ignore bump script with mypy

* Remove unnecessary type ignore

* Exclude file in pre-commit config

---------

Co-authored-by: David Brochart <[email protected]>

Author: brichet

.pre-commit-config.yaml

@@ -60,7 +60,7 @@ repos:
     rev: v0.991
     hooks:
       - id: mypy
-        exclude: "(^binder/jupyter_config\\.py$)|(/setup\\.py$)"
+        exclude: "(^binder/jupyter_config\\.py$)|(^scripts/bump_version\\.py$)|(/setup\\.py$)"
         args: ["--config-file", "pyproject.toml"]
         additional_dependencies: [tornado, pytest]
         stages: [manual]

pyproject.toml

@@ -111,6 +111,7 @@ filterwarnings = [
 [tool.mypy]
 exclude=[
     "^binder/jupyter_config\\.py$",
+    "^scripts/bump_version\\.py$",
     "/setup\\.py$",
 ]
 check_untyped_defs = true

scripts/bump_version.py

@@ -7,7 +7,7 @@
 import click
 import tomlkit
 from jupyter_releaser.util import get_version, run
-from pkg_resources import parse_version  # type: ignore
+from pkg_resources import parse_version
 
 LERNA_CMD = "jlpm run lerna version --no-push --force-publish --no-git-tag-version"