Skip to content

Use hash to check if the file has changed on disk #340

@krassowski

Description

@krassowski

Now that we use the file hash, we could use it to check if the server was the one who saved the file last, instead of using timestamps (see jupyter-server/jupyter_server#1367 (comment) and jupyterlab/jupyterlab#14031 (comment)). This could be done in another PR.

Originally posted by @davidbrochart in #337 (comment)

Upstream JupyterLab checks hash if present and if not then falls back to timestamp comparison. There are some cases when hash is better because touching file when changing branches or similar (but keeping the content the same) does change timestamp but not the hash. hash is only available with newer jupyter-server (2.11.1 or newer).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions