Remove duplicate cells on document change#555
Open
jordanhboxer wants to merge 3 commits intojupyterlab:mainfrom
Open
Remove duplicate cells on document change#555jordanhboxer wants to merge 3 commits intojupyterlab:mainfrom
jordanhboxer wants to merge 3 commits intojupyterlab:mainfrom
Conversation
…ange Add _remove_duplicate_cells to DocumentRoom, triggered when cells change via _on_document_change. This prevents duplicate cells from accumulating when multiple clients sync notebook content concurrently. Also extends rtc_create_mock_document_room fixture with file_format and file_type params to support notebook-type rooms in tests. PY-1190 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
|
Author
|
@davidbrochart @krassowski another couple of changes related to cell duplication (also #556). unfortunately this has been a bit of a thorn in our sides but with the amazing help of @pablogsal we've been able to reproduce a situation where concurrent out-of-band updates cause things to blow up so these two commit will guard against that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_remove_duplicate_cellstoDocumentRoom, triggered when cells change via_on_document_changertc_create_mock_document_roomfixture withfile_formatandfile_typeparams to support notebook-type rooms in testsTest plan
tests/test_rooms.pyverifies duplicate cell removalRelated
#545
jupyter-server/jupyter_ydoc#376
jupyter-server/jupyter_ydoc#385