Add configurables to control ystore.db history and cleanup frequency #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…store cleanup control
|
|
|
From discussion in #430, I think we should set some default value for |
Darshan808
force-pushed
the
ystore-history-cleanup-config
branch
from
b2c58e9 to
ebc2b70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #430
Description
This PR introduces two new configurables to
SQLiteYStoreclass which are introduced in y-crdt/pycrdt-store#2:history_length: Maximum age (in seconds) of document history to retain in the YStore. Older entries are pruned. Defaults to None (no pruning).min_cleanup_interval: Minimum interval (in seconds) between automatic cleanup operations. Defaults to 60 seconds.These options provide better control over the size of
ystore.db, which can grow significantly over time.