Skip to content

Conversation

davidbrochart
Copy link
Collaborator

No description provided.

Copy link
Contributor

Binder 👈 Launch a Binder on branch davidbrochart/jupyter_collaboration/pycrdt-websocket-v0.16.0

@davidbrochart
Copy link
Collaborator Author

Not sure about Test Minimum Versions failing with:

The conflict is caused by:
    jupyter-server-ydoc 2.1.0rc0 depends on pycrdt
    jupyter-server-ydoc[test] 2.1.0rc0 depends on pycrdt
    jupyter-ydoc 2.1.2 depends on pycrdt<0.11.0 and >=0.10.1
    pycrdt-websocket 0.16.0 depends on pycrdt<0.13.0 and >=0.12.16

@krassowski
Copy link
Member

Well, that makes sense to me, jupyter-ydoc is pinned to older version of pycrdt than pycrdt-websocket. This ought to be fixed otherwise pip check will be failing for everyone and packagers will be sad.

@davidbrochart
Copy link
Collaborator Author

jupyter-ydoc v3.0.5 pins pycrdt >=0.10.1,<0.13.0, so this is fine. But I guess the error means that we should not allow jupyter-ydoc v2.1.2 here, but require jupyter-ydoc >=3.0.5?

@davidbrochart
Copy link
Collaborator Author

CI is passing now.

@davidbrochart
Copy link
Collaborator Author

@krassowski I'm not sure we can merge this while in a RC process?

@krassowski
Copy link
Member

If we can wait a bit here I think it would be better.

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @davidbrochart!

@krassowski krassowski changed the title Bump pycrdt-websocket v0.16.0 Bump pycrdt-websocket to v0.16.0 Aug 22, 2025
@krassowski krassowski merged commit b488a2b into jupyterlab:main Aug 22, 2025
28 checks passed
@davidbrochart davidbrochart deleted the pycrdt-websocket-v0.16.0 branch August 22, 2025 11:59
@krassowski
Copy link
Member

I will go ahead and release a new version with this PR in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants