From b9768cf5197a2a630cbab2856fd99955f1e56c52 Mon Sep 17 00:00:00 2001 From: Angus Hollands Date: Thu, 13 Nov 2025 18:13:26 +0000 Subject: [PATCH] fix: clean up background tasks on close --- projects/jupyter-server-ydoc/jupyter_server_ydoc/handlers.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/projects/jupyter-server-ydoc/jupyter_server_ydoc/handlers.py b/projects/jupyter-server-ydoc/jupyter_server_ydoc/handlers.py index 727cce0b..e1841582 100644 --- a/projects/jupyter-server-ydoc/jupyter_server_ydoc/handlers.py +++ b/projects/jupyter-server-ydoc/jupyter_server_ydoc/handlers.py @@ -345,6 +345,10 @@ def on_close(self) -> None: if self._room_id != "JupyterLab:globalAwareness": self._emit_awareness_event(self.current_user.username, "leave") + # Clean up any background tasks once we're done' + for task in self._background_tasks: + task.cancel() + def _emit(self, level: LogLevel, action: str | None = None, msg: str | None = None) -> None: _, _, file_id = decode_file_path(self._room_id) path = self._file_id_manager.get_path(file_id)