remove set_jupyterlab_version CLI

Author: mbektas

.github/workflows/sync_lab_release.yml

@@ -41,7 +41,6 @@ jobs:
           set -eux
           export LATEST=$(python scripts/get_latest_lab_version.py)
           echo "latest=${LATEST}" >> $GITHUB_ENV
-          yarn set_jupyterlab_version ${LATEST}
           if [[ ! -z "$(git status --porcelain package.json)" ]]; then
             tbump --only-patch ${LATEST}-1 --non-interactive
             yarn install

package.json

@@ -29,7 +29,6 @@
     "create_env_installer:mac": "rimraf ./env_installer/JupyterLab*.sh && constructor ./env_installer --platform=osx-64 --output-dir ./env_installer",
     "create_env_installer:win": "rimraf ./env_installer/JupyterLab*.exe && constructor ./env_installer --platform=win-64 --output-dir ./env_installer",
     "check_version_match": "node scripts/buildutil.js --check-version-match",
-    "set_jupyterlab_version": "node scripts/buildutil.js --set-jupyterlab-version",
     "eslint": "eslint --ext .js,.jsx,.ts,.tsx --cache --fix .",
     "eslint:check": "eslint --ext .js,.jsx,.ts,.tsx --cache .",
     "eslint:check:typed": "eslint --config .eslintrc.typecheck.js --ext .js,.jsx,.ts,.tsx .",

scripts/buildutil.js

@@ -13,7 +13,6 @@ const cli = meow(
 
     Options
       --check-version-match      check for JupyterLab version match
-      --set-jupyterlab-version   set JupyterLab version
 
     Other options:
       --help                     show usage information
@@ -27,61 +26,11 @@ const cli = meow(
       checkVersionMatch: {
         type: 'boolean',
         default: false
-      },
-      setJupyterlabVersion: {
-        type: 'string',
-        default: ''
       }
     }
   }
 );
 
-// remove ~ or ^ prefix from semver version
-function makeVersionAbsolute(version) {
-  if (version.length > 0 && (version[0] === '^' || version[0] === '~')) {
-    return version.substring(1);
-  }
-
-  return version;
-}
-
-/*
- * Checks if JupyterLab extensions listed in package.json
- * are properly included into the bundle in "extensions/index.ts"
- */
-function checkExtensionImports() {
-  console.log('Checking for missing extension imports...');
-
-  const pkgjsonFileData = fs.existsSync(pkgjsonFilePath)
-    ? fs.readJSONSync(pkgjsonFilePath)
-    : undefined;
-  if (!pkgjsonFileData) {
-    console.error('package.json not found!');
-    process.exit(1);
-  }
-
-  const extensions = pkgjsonFileData.jupyterlab.extensions;
-  const mimeExtensions = pkgjsonFileData.jupyterlab.mimeExtensions;
-  const extensionsFilePath = path.resolve(
-    __dirname,
-    `../src/browser/extensions/index.ts`
-  );
-  let extensionsFileContent = '';
-  try {
-    extensionsFileContent = fs.readFileSync(extensionsFilePath, 'utf8');
-  } catch (e) {
-    console.error('Error loading "extensions/index.ts"', e);
-  }
-  for (const extension of [...extensions, ...mimeExtensions]) {
-    if (!extensionsFileContent.includes(`require('${extension}')`)) {
-      console.error(`${extension} is not imported in "extensions/index.ts"`);
-      process.exit(1);
-    }
-  }
-
-  console.log('All extensions are bundled correctly.');
-}
-
 if (cli.flags.checkVersionMatch) {
   // parse application version
   const pkgjsonFileData = fs.existsSync(pkgjsonFilePath)
@@ -139,115 +88,3 @@ if (cli.flags.checkVersionMatch) {
   console.log('JupyterLab version match satisfied!');
   process.exit(0);
 }
-
-if (cli.flags.setJupyterlabVersion !== '') {
-  const https = require('https');
-  const newVersion = cli.flags.setJupyterlabVersion;
-  console.log(`Downloading JupyterLab v${newVersion} package.json`);
-
-  const url = `https://raw.githubusercontent.com/jupyterlab/jupyterlab/v${newVersion}/jupyterlab/staging/package.json`;
-
-  https
-    .get(url, res => {
-      let body = '';
-
-      res.on('data', chunk => {
-        body += chunk;
-      });
-
-      res.on('end', () => {
-        try {
-          let newPkgData = JSON.parse(body);
-          if (!(newPkgData.devDependencies && newPkgData.resolutions)) {
-            console.error(`Invalid package.json format for v${newVersion}!`);
-            process.exit(1);
-          }
-
-          const newResolutions = { ...newPkgData.resolutions };
-          const newDependencies = {
-            ...newPkgData.devDependencies,
-            ...newResolutions
-          };
-
-          const pkgjsonFileData = fs.existsSync(pkgjsonFilePath)
-            ? fs.readJSONSync(pkgjsonFilePath)
-            : undefined;
-          if (!pkgjsonFileData) {
-            console.error('package.json not found!');
-            process.exit(1);
-          }
-
-          const oldDependencies = pkgjsonFileData.dependencies;
-
-          for (const packageName in oldDependencies) {
-            if (
-              packageName.startsWith('@jupyterlab') &&
-              packageName in newDependencies
-            ) {
-              oldDependencies[packageName] = makeVersionAbsolute(
-                newDependencies[packageName]
-              );
-            }
-          }
-
-          // copy resolutions and singleton packages as-is
-          pkgjsonFileData.resolutions = newResolutions;
-          pkgjsonFileData.singletonPackages = newPkgData.singletonPackages;
-
-          fs.writeFileSync(
-            pkgjsonFilePath,
-            JSON.stringify(pkgjsonFileData, null, 2)
-          );
-
-          console.log(`JupyterLab dependencies updated to v${newVersion}`);
-
-          checkExtensionImports();
-
-          // Check if all extensions of the new JupyterLab version are
-          // bundled into the application
-          console.log('Checking for extension list match...');
-          const extensions = pkgjsonFileData.jupyterlab.extensions;
-          const mimeExtensions = pkgjsonFileData.jupyterlab.mimeExtensions;
-          const excludedExtensions =
-            pkgjsonFileData.jupyterlab.excludedExtensions;
-
-          const extensionSet = new Set([...extensions, ...excludedExtensions]);
-          const mimeExtensionSet = new Set([
-            ...mimeExtensions,
-            ...excludedExtensions
-          ]);
-
-          for (const extension in newPkgData.jupyterlab.extensions) {
-            if (!extensionSet.has(extension)) {
-              console.error(
-                `JupyterLab v${newVersion} ${extension} is not bundled into the application!`
-              );
-              process.exit(1);
-            }
-          }
-
-          for (const extension in newPkgData.jupyterlab.mimeExtensions) {
-            if (!mimeExtensionSet.has(extension)) {
-              console.error(
-                `JupyterLab v${newVersion} ${extension} is not bundled into the application!`
-              );
-              process.exit(1);
-            }
-          }
-
-          console.log(
-            'All extensions in the new version are bundled correctly.'
-          );
-
-          process.exit(0);
-        } catch (error) {
-          console.error(error.message);
-          process.exit(1);
-        }
-      });
-    })
-    .on('error', error => {
-      console.error(error.message);
-      process.exit(1);
-    });
-}