From 7b1afd5b2ed12a8c7994174c050584d8d24d8fab Mon Sep 17 00:00:00 2001
From: krassowski <5832902+krassowski@users.noreply.github.com>
Date: Mon, 15 Sep 2025 12:46:32 +0100
Subject: [PATCH 1/2] Add review guidance

---
 dev.md | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/dev.md b/dev.md
index 0063459f..00254569 100644
--- a/dev.md
+++ b/dev.md
@@ -85,6 +85,40 @@ JupyterLab Desktop bundles JupyterLab front-end and a conda environment as Jupyt
 
   Application Installer will be created in `dist/JupyterLab.dmg` (macOS), `dist/JupyterLab.deb` (Debian, Ubuntu), `dist/JupyterLab.rpm` (Red Hat, Fedora) and `dist/JupyterLab-Setup.exe` (Windows) based on the platform
 
+## Review guidance
+
+Expected manual testing coverage depends on the PR, when pulling:
+- patch releases of JupyterLab or Electron: Testing on a single OS is sufficient.
+- minor or major JupyterLab releases and minor Electron releases: Test on multiple OSes.
+- major Electron releases: Test on all OSes.
+
+A release PR must be approved by at least two people.
+
+### Key Checks
+
+Depending on the PR, different part of the application may require testing. Use the guide below, but exercise your own judgment to skip or add more checks depending on circumstances.
+
+For patch dependency update PRs:
+- [ ] Notebooks UI launches (smoke test, no extensive testing required)
+
+For minor and major JupyterLab update PRs:
+- [ ] JupyterLab Desktop theme switching works
+- [ ] UI Mode switching works
+
+For conda update PRs:
+- [ ] Creating new environments from "Manage Python Environments" dialog works
+- [ ] The environment picker popover shows up with a list of environments
+- [ ] Switching environments works
+
+For minor and major Electron updates PR:
+- [ ] All checks listed above
+- [ ] No new errors in log files (e.g. `~/Library/Logs/jupyterlab-desktop/main.log`) and when launching from terminal with `jlab`
+- [ ] The welcome screen opens, displays the news feed, recent sessions, and allows to create new sessions
+- [ ] The settings window opens
+
+Before JupyterLab Desktop release:
+- [ ] All checks listed above
+
 ## Release Instructions
 
 For instructions on updating bundled JupyterLab packages and cutting a new release, please follow [Release.md](Release.md) document.

From b77996cae099146d2c5efeb7b1c8bd869e2532a0 Mon Sep 17 00:00:00 2001
From: krassowski <5832902+krassowski@users.noreply.github.com>
Date: Mon, 15 Sep 2025 13:14:47 +0100
Subject: [PATCH 2/2] Lint

---
 dev.md | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/dev.md b/dev.md
index 00254569..3f2fdb0d 100644
--- a/dev.md
+++ b/dev.md
@@ -88,6 +88,7 @@ JupyterLab Desktop bundles JupyterLab front-end and a conda environment as Jupyt
 ## Review guidance
 
 Expected manual testing coverage depends on the PR, when pulling:
+
 - patch releases of JupyterLab or Electron: Testing on a single OS is sufficient.
 - minor or major JupyterLab releases and minor Electron releases: Test on multiple OSes.
 - major Electron releases: Test on all OSes.
@@ -99,24 +100,29 @@ A release PR must be approved by at least two people.
 Depending on the PR, different part of the application may require testing. Use the guide below, but exercise your own judgment to skip or add more checks depending on circumstances.
 
 For patch dependency update PRs:
+
 - [ ] Notebooks UI launches (smoke test, no extensive testing required)
 
 For minor and major JupyterLab update PRs:
+
 - [ ] JupyterLab Desktop theme switching works
 - [ ] UI Mode switching works
 
 For conda update PRs:
+
 - [ ] Creating new environments from "Manage Python Environments" dialog works
 - [ ] The environment picker popover shows up with a list of environments
 - [ ] Switching environments works
 
 For minor and major Electron updates PR:
+
 - [ ] All checks listed above
 - [ ] No new errors in log files (e.g. `~/Library/Logs/jupyterlab-desktop/main.log`) and when launching from terminal with `jlab`
 - [ ] The welcome screen opens, displays the news feed, recent sessions, and allows to create new sessions
 - [ ] The settings window opens
 
 Before JupyterLab Desktop release:
+
 - [ ] All checks listed above
 
 ## Release Instructions