Skip to content

Commit 03526ed

Browse files
committed
Remove middle header label
1 parent dbe6985 commit 03526ed

File tree

1 file changed

+18
-10
lines changed

1 file changed

+18
-10
lines changed

src/components/diff/NotebookDiff.ts

Lines changed: 18 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -188,8 +188,8 @@ export class NotebookDiff
188188

189189
const header = Private.diffHeader(
190190
this._model.reference.label,
191-
this._model.base?.label,
192-
this._model.challenger.label
191+
this._model.challenger.label,
192+
this._hasConflict
193193
);
194194
this.addWidget(header);
195195

@@ -312,16 +312,24 @@ namespace Private {
312312
/**
313313
* Create a header widget for the diff view.
314314
*/
315-
export function diffHeader(...labels: string[]): Widget {
315+
export function diffHeader(
316+
baseLabel: string,
317+
remoteLabel: string,
318+
hasConflict: boolean
319+
): Widget {
316320
const node = document.createElement('div');
317321
node.className = 'jp-git-diff-header';
318-
node.innerHTML = `
319-
<div class="jp-git-diff-banner">
320-
${labels
321-
.filter(label => !!label)
322-
.map(label => `<span>${label}</span>`)
323-
.join('<span class="jp-spacer"></span>')}
324-
</div>`;
322+
node.innerHTML = `<div class="jp-git-diff-banner">
323+
<span>${baseLabel}</span>
324+
<span class="jp-spacer"></span>
325+
${
326+
hasConflict
327+
? // Add extra space during notebook merge view
328+
'<span>&nbsp;</span><span class="jp-spacer"></span>'
329+
: ''
330+
}
331+
<span>${remoteLabel}</span>
332+
</div>`;
325333

326334
return new Widget({ node });
327335
}

0 commit comments

Comments
 (0)