Merge pull request #650 from fcollonval/issue642

Test for `response.ok` not `status === 200`

Author: fcollonval

src/model.ts

@@ -259,7 +259,7 @@ export class GitExtension implements IGitExtension {
       const response = await httpGitRequest('/git/add_all_unstaged', 'POST', {
         top_repo_path: path
       });
-      if (response.status !== 200) {
+      if (!response.ok) {
         const data = await response.json();
         throw new ServerConnection.ResponseError(response, data.message);
       }
@@ -294,7 +294,7 @@ export class GitExtension implements IGitExtension {
       const response = await httpGitRequest('/git/add_all_untracked', 'POST', {
         top_repo_path: path
       });
-      if (response.status !== 200) {
+      if (!response.ok) {
         const data = await response.json();
         throw new ServerConnection.ResponseError(response, data.message);
       }
@@ -355,9 +355,9 @@ export class GitExtension implements IGitExtension {
         url,
         name
       });
-      if (response.status !== 200) {
-        const data = await response.text();
-        throw new ServerConnection.ResponseError(response, data);
+      if (!response.ok) {
+        const data = await response.json();
+        throw new ServerConnection.ResponseError(response, data.message);
       }
     } catch (err) {
       throw new ServerConnection.NetworkError(err);
@@ -387,9 +387,9 @@ export class GitExtension implements IGitExtension {
         current_path: path,
         history_count: historyCount
       });
-      if (response.status !== 200) {
-        const data = await response.text();
-        throw new ServerConnection.ResponseError(response, data);
+      if (!response.ok) {
+        const data = await response.json();
+        throw new ServerConnection.ResponseError(response, data.message);
       }
       return response.json();
     } catch (err) {
@@ -446,7 +446,7 @@ export class GitExtension implements IGitExtension {
 
     try {
       const response = await httpGitRequest('/git/checkout', 'POST', body);
-      if (response.status !== 200) {
+      if (!response.ok) {
         return response.json().then((data: any) => {
           throw new ServerConnection.ResponseError(response, data.message);
         });
@@ -484,7 +484,7 @@ export class GitExtension implements IGitExtension {
       };
 
       const response = await httpGitRequest('/git/clone', 'POST', obj);
-      if (response.status !== 200) {
+      if (!response.ok) {
         const data = await response.json();
         throw new ServerConnection.ResponseError(response, data.message);
       }
@@ -519,7 +519,7 @@ export class GitExtension implements IGitExtension {
         commit_msg: message,
         top_repo_path: path
       });
-      if (response.status !== 200) {
+      if (!response.ok) {
         return response.json().then((data: any) => {
           throw new ServerConnection.ResponseError(response, data.message);
         });
@@ -597,7 +597,7 @@ export class GitExtension implements IGitExtension {
         commit_id: commitId,
         top_repo_path: path
       });
-      if (response.status !== 200) {
+      if (!response.ok) {
         return response.json().then((data: any) => {
           throw new ServerConnection.ResponseError(response, data.message);
         });
@@ -631,7 +631,7 @@ export class GitExtension implements IGitExtension {
         selected_hash: hash,
         current_path: path
       });
-      if (response.status !== 200) {
+      if (!response.ok) {
         const data = await response.json();
         throw new ServerConnection.ResponseError(response, data.message);
       }
@@ -682,7 +682,7 @@ export class GitExtension implements IGitExtension {
       const response = await httpGitRequest('/git/init', 'POST', {
         current_path: path
       });
-      if (response.status !== 200) {
+      if (!response.ok) {
         return response.json().then((data: any) => {
           throw new ServerConnection.ResponseError(response, data.message);
         });
@@ -714,7 +714,7 @@ export class GitExtension implements IGitExtension {
         current_path: path,
         history_count: historyCount
       });
-      if (response.status !== 200) {
+      if (!response.ok) {
         const data = await response.json();
         throw new ServerConnection.ResponseError(response, data.message);
       }
@@ -758,7 +758,7 @@ export class GitExtension implements IGitExtension {
       };
 
       const response = await httpGitRequest('/git/pull', 'POST', obj);
-      if (response.status !== 200) {
+      if (!response.ok) {
         const data = await response.json();
         throw new ServerConnection.ResponseError(response, data.message);
       }
@@ -790,7 +790,7 @@ export class GitExtension implements IGitExtension {
       };
 
       const response = await httpGitRequest('/git/push', 'POST', obj);
-      if (response.status !== 200) {
+      if (!response.ok) {
         const data = await response.json();
         throw new ServerConnection.ResponseError(response, data.message);
       }
@@ -846,7 +846,7 @@ export class GitExtension implements IGitExtension {
         current_path: path
       });
       const data = await response.json();
-      if (response.status !== 200) {
+      if (!response.ok) {
         console.error(data.message);
         // TODO should we notify the user
         this._setStatus([]);
@@ -892,7 +892,7 @@ export class GitExtension implements IGitExtension {
         filename: filename === undefined ? null : filename,
         top_repo_path: path
       });
-      if (response.status !== 200) {
+      if (!response.ok) {
         return response.json().then((data: any) => {
           throw new ServerConnection.ResponseError(response, data.message);
         });
@@ -932,7 +932,7 @@ export class GitExtension implements IGitExtension {
         commit_id: commitId,
         top_repo_path: path
       });
-      if (response.status !== 200) {
+      if (!response.ok) {
         return response.json().then((data: any) => {
           throw new ServerConnection.ResponseError(response, data.message);
         });
@@ -953,7 +953,7 @@ export class GitExtension implements IGitExtension {
       const response = await httpGitRequest('/git/show_prefix', 'POST', {
         current_path: path
       });
-      if (response.status !== 200) {
+      if (!response.ok) {
         const data = await response.json();
         throw new ServerConnection.ResponseError(response, data.message);
       }
@@ -969,7 +969,7 @@ export class GitExtension implements IGitExtension {
       const response = await httpGitRequest('/git/show_top_level', 'POST', {
         current_path: path
       });
-      if (response.status !== 200) {
+      if (!response.ok) {
         const data = await response.json();
         throw new ServerConnection.ResponseError(response, data.message);
       }
@@ -999,7 +999,7 @@ export class GitExtension implements IGitExtension {
       const response = await httpGitRequest('/git/branch', 'POST', {
         current_path: path
       });
-      if (response.status !== 200) {
+      if (!response.ok) {
         const data = await response.json();
         throw new ServerConnection.ResponseError(response, data.message);
       }