Merge pull request #556 from chrisjohn2306/exception_handling_scenarios

Updating Exception Handling Scenarios

Author: telamonian

src/components/Toolbar.tsx

@@ -48,7 +48,6 @@ async function showGitOperationDialog(
   });
   let retry = false;
   while (!result.button.accept) {
-    retry = true;
     const credentials = await showDialog({
       title: 'Git credentials required',
       body: new GitCredentialsForm(
@@ -57,14 +56,17 @@ async function showGitOperationDialog(
       ),
       buttons: [Dialog.cancelButton(), Dialog.okButton({ label: 'OK' })]
     });
+
     if (!credentials.button.accept) {
       break;
     }
+
     result = await showDialog({
       title: title,
       body: new GitPullPushDialog(model, operation, credentials.value),
       buttons: [Dialog.okButton({ label: 'DISMISS' })]
     });
+    retry = true;
   }
 }
 

src/widgets/gitClone.tsx

@@ -84,6 +84,11 @@ async function makeApiCall(
           ]);
           break;
         }
+      } else {
+        showErrorMessage('Clone failed', response.message, [
+          Dialog.warnButton({ label: 'DISMISS' })
+        ]);
+        break;
       }
     }
   } catch (error) {