Skip to content

Commit 5307d77

Browse files
committed
reduced min rows in commit msg box to 2, improved placeholder msg
1 parent f7c1bde commit 5307d77

File tree

3 files changed

+20
-7
lines changed

3 files changed

+20
-7
lines changed

src/components/CommitBox.tsx

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import { ISettingRegistry } from '@jupyterlab/coreutils';
2+
13
import * as React from 'react';
24
import TextareaAutosize from 'react-textarea-autosize';
35
import { classes } from 'typestyle';
@@ -14,6 +16,7 @@ import {
1416
export interface ICommitBoxProps {
1517
hasFiles: boolean;
1618
commitFunc: (message: string) => Promise<void>;
19+
settings: ISettingRegistry.ISettings;
1720
}
1821

1922
export interface ICommitBoxState {
@@ -78,13 +81,9 @@ export class CommitBox extends React.Component<
7881
<TextareaAutosize
7982
className={classes(textInputStyle, stagedCommitMessageStyle)}
8083
disabled={!this.props.hasFiles}
81-
minRows={3}
84+
minRows={2}
8285
onChange={this.handleChange}
83-
placeholder={
84-
this.props.hasFiles
85-
? 'Input message to commit staged changes'
86-
: 'Stage your changes before commit'
87-
}
86+
placeholder={this._placeholder()}
8887
value={this.state.value}
8988
/>
9089
<input
@@ -100,4 +99,16 @@ export class CommitBox extends React.Component<
10099
</form>
101100
);
102101
}
102+
103+
protected _placeholder = (): string => {
104+
if (this.props.settings.composite['simpleStaging']) {
105+
return this.props.hasFiles
106+
? 'Input message to commit selected changes'
107+
: 'Select changes to enable commit';
108+
} else {
109+
return this.props.hasFiles
110+
? 'Input message to commit staged changes'
111+
: 'Stage your changes before commit';
112+
}
113+
};
103114
}

src/components/FileList.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -512,6 +512,7 @@ export class FileList extends React.Component<IFileListProps, IFileListState> {
512512
<CommitBox
513513
hasFiles={this.markedFiles.length > 0}
514514
commitFunc={this.commitAllMarkedFiles}
515+
settings={this.props.settings}
515516
/>
516517
<div>
517518
<GitStageSimple
@@ -531,6 +532,7 @@ export class FileList extends React.Component<IFileListProps, IFileListState> {
531532
<CommitBox
532533
hasFiles={this.props.stagedFiles.length > 0}
533534
commitFunc={this.commitAllStagedFiles}
535+
settings={this.props.settings}
534536
/>
535537
<div>
536538
<Staged />

src/style/BranchHeaderStyle.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ export const stagedCommitButtonStyle = style({
9696
color: 'white',
9797
flex: '1 1 auto',
9898
fontSize: 'var(--jp-ui-font-size1)',
99-
height: 'calc(3em + 9px)',
99+
height: 'calc(2 * (1.25em - 1px))',
100100
padding: 'calc(var(--jp-code-padding) + 1px) 7px',
101101
width: '40px'
102102
});

0 commit comments

Comments
 (0)