Skip to content

Commit 6598448

Browse files
author
Frederic Collonval
committed
Improvments from review
1 parent 97ff981 commit 6598448

File tree

2 files changed

+20
-20
lines changed

2 files changed

+20
-20
lines changed

src/components/SinglePastCommitInfo.tsx

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { JupyterFrontEnd } from '@jupyterlab/application';
22
import { IRenderMimeRegistry } from '@jupyterlab/rendermime';
3-
import { defaultIconRegistry } from '@jupyterlab/ui-components';
3+
import { DefaultIconReact } from '@jupyterlab/ui-components';
44
import * as React from 'react';
55
import { classes } from 'typestyle/';
66
import { fileIconStyle } from '../style/FileItemStyle';
@@ -139,30 +139,30 @@ export class SinglePastCommitInfo extends React.Component<
139139
<div className={commitStyle}>
140140
<div className={commitOverviewNumbers}>
141141
<span>
142-
{defaultIconRegistry.iconReact({
143-
name: 'file',
144-
className: classes(iconStyle),
145-
tag: 'span',
146-
title: '# Files Changed'
147-
})}
142+
<DefaultIconReact
143+
name="file"
144+
className={iconStyle}
145+
tag="span"
146+
title="# Files Changed"
147+
/>
148148
{this.state.filesChanged}
149149
</span>
150150
<span>
151-
{defaultIconRegistry.iconReact({
152-
name: 'git-insertionsMade',
153-
className: classes(iconStyle),
154-
tag: 'span',
155-
title: '# Insertions'
156-
})}
151+
<DefaultIconReact
152+
name="git-insertionsMade"
153+
className={iconStyle}
154+
tag="span"
155+
title="# Insertions"
156+
/>
157157
{this.state.insertionCount}
158158
</span>
159159
<span>
160-
{defaultIconRegistry.iconReact({
161-
name: 'git-deletionsMade',
162-
className: classes(iconStyle),
163-
tag: 'span',
164-
title: '# Deletions'
165-
})}
160+
<DefaultIconReact
161+
name="git-deletionsMade"
162+
className={iconStyle}
163+
tag="span"
164+
title="# Deletions"
165+
/>
166166
{this.state.deletionCount}
167167
</span>
168168
</div>

style/variables.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
--jp-icon-discard-file: url('./images/discard-selected.svg');
4343
--jp-icon-git-pull: url('./images/git-pull-white.svg');
4444
--jp-icon-git-push: url('./images/git-push-white.svg');
45-
--jp-icon-move-file-down-white: url('./images/move-file-down-hover.svg');
45+
--jp-icon-move-file-down: url('./images/move-file-down-hover.svg');
4646
--jp-icon-move-file-up: url('./images/move-file-up-hover.svg');
4747
--jp-icon-plus: url('./images/plus-white.svg');
4848
--jp-icon-rewind: url('./images/rewind-white.svg');

0 commit comments

Comments
 (0)