Skip to content

Commit 736193c

Browse files
committed
Add unit tests
1 parent dce5441 commit 736193c

File tree

5 files changed

+170
-159
lines changed

5 files changed

+170
-159
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"clean:slate": "jlpm clean:more && jlpm clean:labextension && rimraf node_modules",
2222
"contributors:generate": "jlpm run all-contributors generate",
2323
"lint": "eslint . --ext .ts,.tsx --fix",
24-
"test": "jest --no-cache",
24+
"test": "jest",
2525
"eslint-check": "eslint . --ext .ts,.tsx",
2626
"prepare": "jlpm run build",
2727
"watch": "tsc -w"

src/components/BranchMenu.tsx

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { Logger } from '../logger';
99
import { hiddenButtonStyle } from '../style/ActionButtonStyle';
1010
import {
1111
activeListItemClass,
12-
branchNameClass,
12+
nameClass,
1313
filterClass,
1414
filterClearClass,
1515
filterInputClass,
@@ -257,7 +257,7 @@ export class BranchMenu extends React.Component<
257257
style={style}
258258
>
259259
<branchIcon.react className={listItemIconClass} tag="span" />
260-
<span className={branchNameClass}>{branch.name}</span>
260+
<span className={nameClass}>{branch.name}</span>
261261
{!branch.is_remote_branch && !isActive && (
262262
<ActionButton
263263
className={hiddenButtonStyle}
@@ -329,7 +329,11 @@ export class BranchMenu extends React.Component<
329329
buttons: [Dialog.cancelButton(), Dialog.warnButton({ label: 'Delete' })]
330330
});
331331
if (acknowledgement.button.accept) {
332-
await this.props.model.deleteBranch(branchName);
332+
try {
333+
await this.props.model.deleteBranch(branchName);
334+
} catch (error) {
335+
console.error(`Failed to delete branch ${branchName}`, error);
336+
}
333337
}
334338
};
335339

src/components/TagMenu.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import * as React from 'react';
66
import { FixedSizeList, ListChildComponentProps } from 'react-window';
77
import { Logger } from '../logger';
88
import {
9-
branchNameClass,
9+
nameClass,
1010
filterClass,
1111
filterClearClass,
1212
filterInputClass,
@@ -242,7 +242,7 @@ export class TagMenu extends React.Component<ITagMenuProps, ITagMenuState> {
242242
style={style}
243243
>
244244
<tagIcon.react className={listItemIconClass} tag="span" />
245-
<span className={branchNameClass}>{tag}</span>
245+
<span className={nameClass}>{tag}</span>
246246
</ListItem>
247247
);
248248
};

src/style/BranchMenu.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { style } from 'typestyle';
22
import { showButtonOnHover } from './ActionButtonStyle';
33

4-
export const branchNameClass = style({
4+
export const nameClass = style({
55
flex: '1 1 auto',
66
textOverflow: 'ellipsis',
77
overflow: 'hidden',

0 commit comments

Comments
 (0)