Skip to content

Commit de2bf9c

Browse files
authored
fixes #1121 by trimming whitespace from user input of clone URI path (#1122)
* fixes #1121 by trimming whitespace from user input of clone URI path * Update README.md
1 parent 03ae7b6 commit de2bf9c

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ git clone https://github.com/jupyterlab/jupyterlab-git.git
207207
# Change directory to the jupyterlab-git directory
208208
cd jupyterlab-git
209209
# Install package in development mode
210-
pip install -e .[dev]
210+
pip install -e ".[dev]"
211211
pre-commit install
212212
# Link your development version of the extension with JupyterLab
213213
jupyter labextension develop . --overwrite

src/widgets/GitCloneForm.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export class GitCloneForm extends Widget {
1717
* Returns the input value.
1818
*/
1919
getValue(): string {
20-
return encodeURIComponent(this.node.querySelector('input').value);
20+
return encodeURIComponent(this.node.querySelector('input').value.trim());
2121
}
2222

2323
private static createFormNode(trans: TranslationBundle): HTMLElement {

0 commit comments

Comments
 (0)