Skip to content

Commit f153938

Browse files
committed
Fix viewing merge conflict diff in notebooks
1 parent 9fdbb29 commit f153938

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

jupyterlab_git/git.py

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -351,15 +351,25 @@ def read_notebook(content):
351351
else:
352352
return nbformat.reads(content, as_version=4)
353353

354+
def remove_cell_ids(nb):
355+
for cell in nb.cells:
356+
del cell["id"]
357+
return nb
358+
354359
current_loop = tornado.ioloop.IOLoop.current()
355360
prev_nb = await current_loop.run_in_executor(None, read_notebook, prev_content)
356361
curr_nb = await current_loop.run_in_executor(None, read_notebook, curr_content)
357362
if base_content:
358363
base_nb = await current_loop.run_in_executor(
359364
None, read_notebook, base_content
360365
)
366+
# Only remove ids from merge_notebooks as a workaround
361367
_, merge_decisions = await current_loop.run_in_executor(
362-
None, merge_notebooks, base_nb, prev_nb, curr_nb
368+
None,
369+
merge_notebooks,
370+
remove_cell_ids(base_nb),
371+
remove_cell_ids(prev_nb),
372+
remove_cell_ids(curr_nb),
363373
)
364374

365375
return {"base": base_nb, "merge_decisions": merge_decisions}

0 commit comments

Comments
 (0)