Skip to content

Commit 1508ff8

Browse files
authored
Do not overwrite capitalization of region names (#202)
1 parent 514564e commit 1508ff8

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

jupyterlab_server/tests/test_translation_api.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -219,6 +219,7 @@ def test_get_display_name_valid():
219219
assert get_display_name("en", "fr") == "Anglais"
220220
assert get_display_name("es", "en") == "Spanish"
221221
assert get_display_name("fr", "en") == "French"
222+
assert get_display_name("pl_pl", "en") == "Polish (Poland)"
222223

223224

224225
def test_get_display_name_invalid():

jupyterlab_server/translation_utils.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,10 @@ def get_display_name(locale: str, display_locale: str = DEFAULT_LOCALE) -> str:
164164
display_locale if is_valid_locale(display_locale) else DEFAULT_LOCALE
165165
)
166166
loc = babel.Locale.parse(locale)
167-
return loc.get_display_name(display_locale).capitalize()
167+
display_name = loc.get_display_name(display_locale)
168+
if display_name:
169+
display_name = display_name[0].upper() + display_name[1:]
170+
return display_name
168171

169172

170173
def merge_locale_data(language_pack_locale_data, package_locale_data):

0 commit comments

Comments
 (0)