PR: Update new_defaults dictionary instead of copy (#194)

* Update den defaults dictionary instead of copy

* Fix overrides dict test

Author: goanpeca

jupyterlab_server/settings_handler.py

@@ -220,7 +220,7 @@ def _override(schema_name, schema, overrides):
                 new_defaults = schema['properties'][key]['default']
                 # If values for defaults are dicts do a recursive update
                 if isinstance(new_defaults, dict):
-                    recursive_update(new_defaults.copy(), defaults[key])
+                    recursive_update(new_defaults, defaults[key])
                 else:
                     new_defaults = defaults[key]
 

jupyterlab_server/tests/app-settings/overrides.json

@@ -2,7 +2,7 @@
   "@jupyterlab/apputils-extension:themes": {
     "theme": "JupyterLab Dark",
     "codeCellConfig": {
-      "lineNumbers": false
+      "lineNumbers": true
    }
   },
   "@jupyterlab/unicode-extension:plugin": {

jupyterlab_server/tests/test_settings_api.py

@@ -24,7 +24,7 @@ async def test_get_settings_overrides_dicts(jp_fetch, labserverapp):
     assert data['id'] == id
     schema = data['schema']
     # Check that overrides.json file is respected.
-    assert schema['properties']['codeCellConfig']['default']["lineNumbers"] is False
+    assert schema['properties']['codeCellConfig']['default']["lineNumbers"] is True
     assert len(schema['properties']['codeCellConfig']['default']) == 15