Lint and typing updates (#395)

Author: blink1073

.pre-commit-config.yaml

@@ -36,7 +36,7 @@ repos:
       - id: black
 
   - repo: https://github.com/charliermarsh/ruff-pre-commit
-    rev: v0.0.260
+    rev: v0.0.263
     hooks:
       - id: ruff
         args: ["--fix"]

jupyterlab_server/process.py

@@ -174,7 +174,7 @@ def _create_process(self, **kwargs):
         if os.name == "nt":
             kwargs["shell"] = True
 
-        proc = subprocess.Popen(cmd, **kwargs)
+        proc = subprocess.Popen(cmd, **kwargs)  # noqa
         return proc
 
     @classmethod

jupyterlab_server/test_utils.py

@@ -60,7 +60,7 @@ def __init__(self, request: HTTPRequest, spec: Spec):
 
         self.parameters = RequestParameters(
             query=ImmutableMultiDict(parse_qs(o.query)),
-            header=Headers(dict(request.headers)),
+            header=dict(request.headers),
             cookie=ImmutableMultiDict(cookies),
             path=path,
         )

pyproject.toml

@@ -118,7 +118,7 @@ dependencies = [
   "black[jupyter]==23.3.0",
   "mdformat>0.7",
   "mdformat-gfm>=0.3.5",
-  "ruff==0.0.260"
+  "ruff==0.0.263"
 ]
 detatched = true
 [tool.hatch.envs.lint.scripts]

tests/test_settings_api.py

@@ -124,7 +124,7 @@ async def test_listing_ids(jp_fetch, labserverapp):
 
     # Checks there is only the 'id' key in each item
     assert all(
-        [(len(item.keys()) == 1 and list(item.keys())[0] == 'id') for item in response["settings"]]
+        (len(item.keys()) == 1 and list(item.keys())[0] == 'id') for item in response["settings"]
     )
 
 

tests/test_translation_api.py

@@ -37,13 +37,15 @@ def setup_module(module):
     """setup any state specific to the execution of this module."""
     for pkg in ["jupyterlab-some-package", "jupyterlab-language-pack-es_CO"]:
         src = os.path.join(HERE, "translations", pkg)
-        subprocess.Popen([sys.executable, "-m", "pip", "install", src]).communicate()
+        subprocess.Popen([sys.executable, "-m", "pip", "install", src]).communicate()  # noqa
 
 
 def teardown_module(module):
     """teardown any state that was previously setup."""
     for pkg in ["jupyterlab-some-package", "jupyterlab-language-pack-es_CO"]:
-        subprocess.Popen([sys.executable, "-m", "pip", "uninstall", pkg, "-y"]).communicate()
+        subprocess.Popen(
+            [sys.executable, "-m", "pip", "uninstall", pkg, "-y"]  # noqa
+        ).communicate()
 
 
 @pytest.fixture(autouse=True)