[pre-commit.ci] pre-commit autoupdate (#370)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Steven Silvester <[email protected]>

Author: pre-commit-ci[bot]

.pre-commit-config.yaml

@@ -19,7 +19,7 @@ repos:
       - id: trailing-whitespace
 
   - repo: https://github.com/python-jsonschema/check-jsonschema
-    rev: 0.19.2
+    rev: 0.21.0
     hooks:
       - id: check-github-workflows
 
@@ -31,12 +31,12 @@ repos:
           [mdformat-gfm, mdformat-frontmatter, mdformat-footnote]
 
   - repo: https://github.com/psf/black
-    rev: 22.12.0
+    rev: 23.1.0
     hooks:
       - id: black
 
   - repo: https://github.com/charliermarsh/ruff-pre-commit
-    rev: v0.0.236
+    rev: v0.0.242
     hooks:
       - id: ruff
         args: ["--fix"]

jupyterlab_server/config.py

@@ -79,7 +79,7 @@ def get_static_page_config(app_settings_dir=None, logger=None, level="all"):
     return cm.get("page_config")
 
 
-def get_page_config(labextensions_path, app_settings_dir=None, logger=None):
+def get_page_config(labextensions_path, app_settings_dir=None, logger=None):  # noqa
     """Get the page config for the application handler"""
     # Build up the full page config
     page_config: dict = {}
@@ -113,7 +113,7 @@ def get_page_config(labextensions_path, app_settings_dir=None, logger=None):
     # Ensure there is a disabled key
     page_config.setdefault(disabled_key, {})
 
-    for (_, ext_data) in federated_exts.items():
+    for _, ext_data in federated_exts.items():
         if "_build" not in ext_data["jupyterlab"]:
             logger.warning("%s is not a valid extension" % ext_data["name"])
             continue
@@ -143,7 +143,7 @@ def get_page_config(labextensions_path, app_settings_dir=None, logger=None):
             with open(package_data_file, encoding="utf-8") as fid:
                 app_data = json.load(fid)
             all_ext_data = app_data["jupyterlab"].get("extensionMetadata", {})
-            for (ext, ext_data) in all_ext_data.items():
+            for ext, ext_data in all_ext_data.items():
                 if ext in disabled_by_extensions_all:
                     continue
                 if ext_data.get(disabled_key):
@@ -164,8 +164,7 @@ def get_page_config(labextensions_path, app_settings_dir=None, logger=None):
     page_config[disabled_key] = rollup_disabled
 
     # Convert dictionaries to lists to give to the front end
-    for (key, value) in page_config.items():
-
+    for key, value in page_config.items():
         if isinstance(value, dict):
             page_config[key] = [subkey for subkey in value if value[subkey]]
 

jupyterlab_server/handlers.py

@@ -99,7 +99,7 @@ def get_page_config(self):
                         .as_posix()
                     )
             except Exception:
-                pass  # we do not require the preferred_dir trait to be present
+                pass  # noqa  # we do not require the preferred_dir trait to be present
         # JupyterLab relies on an unset/default path being "/"
         page_config["preferredPath"] = preferred_path or "/"
 
@@ -175,7 +175,7 @@ def get_page_config(self):
         return page_config
 
 
-def add_handlers(handlers, extension_app):
+def add_handlers(handlers, extension_app):  # noqa
     """Add the appropriate handlers to the web app."""
     # Normalize directories.
     for name in LabConfig.class_trait_names():
@@ -246,7 +246,6 @@ def add_handlers(handlers, extension_app):
 
     # Handle saved workspaces.
     if extension_app.workspaces_dir:
-
         workspaces_config = {"manager": WorkspacesManager(extension_app.workspaces_dir)}
 
         # Handle requests for the list of workspaces. Make slash optional.

jupyterlab_server/process.py

@@ -119,7 +119,7 @@ def terminate(self):
         try:
             proc.wait(timeout=2.0)
         except subprocess.TimeoutExpired:
-            if os.name == "nt":
+            if os.name == "nt":  # noqa
                 sig = signal.SIGBREAK  # type:ignore
             else:
                 sig = signal.SIGKILL

jupyterlab_server/server.py

@@ -2,7 +2,7 @@
 # Distributed under the terms of the Modified BSD License.
 
 """Server api."""
-from jupyter_server import _tz as tz  # noqa
+from jupyter_server import _tz as tz
 from jupyter_server.base.handlers import (
     APIHandler,
     FileFindHandler,
@@ -15,5 +15,5 @@
     RED_DISABLED,
     RED_X,
 )
-from jupyter_server.serverapp import ServerApp, aliases, flags  # noqa
-from jupyter_server.utils import url_escape, url_path_join  # noqa
+from jupyter_server.serverapp import ServerApp, aliases, flags
+from jupyter_server.utils import url_escape, url_path_join

jupyterlab_server/test_utils.py

@@ -188,7 +188,7 @@ def maybe_patch_ioloop():
                 set_event_loop_policy(WindowsSelectorEventLoopPolicy())
 
 
-def expected_http_error(error, expected_code, expected_message=None):
+def expected_http_error(error, expected_code, expected_message=None):  # noqa
     """Check that the error matches the expected output error."""
     e = error.value
     if isinstance(e, tornado.web.HTTPError):

jupyterlab_server/translation_utils.py

@@ -159,7 +159,7 @@ def is_valid_locale(locale_: str) -> bool:
         valid = True
     except (babel.core.UnknownLocaleError, ValueError):
         # Expected error if the locale is unknown
-        pass
+        pass  # noqa
 
     return valid
 
@@ -411,7 +411,7 @@ def update_locale(self, locale_: str) -> None:
                 localedir = os.path.join(os.path.dirname(mod.__file__), LOCALE_DIR)
             except Exception:
                 # no-op
-                pass
+                pass  # noqa
 
         self._translator = gettext.translation(
             self._domain, localedir=localedir, languages=(self._locale,), fallback=True

pyproject.toml

@@ -115,10 +115,10 @@ test = "mypy --install-types --non-interactive {args:jupyterlab_server tests}"
 
 [tool.hatch.envs.lint]
 dependencies = [
-  "black[jupyter]==22.12.0",
+  "black[jupyter]==23.1.0",
   "mdformat>0.7",
   "mdformat-gfm>=0.3.5",
-  "ruff==0.0.236"
+  "ruff==0.0.242"
 ]
 detatched = true
 [tool.hatch.envs.lint.scripts]
@@ -233,6 +233,10 @@ ignore = [
 "E501",
 # SIM105 Use `contextlib.suppress(...)`
 "SIM105",
+# PLR0912 Too many branches
+"PLR0912",
+# PLR0913 Too many arguments to function call
+"PLR0913",
 ]
 
 [tool.ruff.per-file-ignores]

tests/test_licenses_api.py

@@ -192,4 +192,4 @@ def a_licenses_manager():
 def test_labextension_bundle(a_fake_labextension, a_licenses_manager):
     ext_path, ext_name = a_fake_labextension
     bundle = a_licenses_manager.license_bundle(ext_path, ext_name)
-    assert bundle["packages"][0]["name"] == dict(FULL_ENTRY)["name"]  # noqa
+    assert bundle["packages"][0]["name"] == dict(FULL_ENTRY)["name"]

tests/test_translation_api.py

@@ -48,7 +48,6 @@ def teardown_module(module):
 
 @pytest.fixture(autouse=True)
 def before_after_test(schemas_dir, user_settings_dir, labserverapp):
-
     # Code that will run before any test.
 
     # Copy the schema files.