Forbid .only and .skip on CI (#745)

fcollonval · web-flow · commit a4abf35b2233 · 2025-03-11T14:18:33.000Z
* Forbid .only and .skip on CI

* Lint the code

---------

Co-authored-by: Frédéric Collonval &lt;fcollonval@users.noreply.github.com&gt;
diff --git a/packages/algorithm/web-test-runner.config.js b/packages/algorithm/web-test-runner.config.js
@@ -0,0 +1,13 @@
+/*
+ * Copyright (c) Jupyter Development Team.
+ * Distributed under the terms of the Modified BSD License.
+ */
+
+module.exports = {
+  testFramework: {
+    config: {
+      forbidOnly: process.env.CI ? true : false,
+      forbidPending: process.env.CI ? true : false
+    }
+  }
+};
diff --git a/packages/application/web-test-runner.config.js b/packages/application/web-test-runner.config.js
@@ -0,0 +1,13 @@
+/*
+ * Copyright (c) Jupyter Development Team.
+ * Distributed under the terms of the Modified BSD License.
+ */
+
+module.exports = {
+  testFramework: {
+    config: {
+      forbidOnly: process.env.CI ? true : false,
+      forbidPending: process.env.CI ? true : false
+    }
+  }
+};
diff --git a/packages/collections/web-test-runner.config.js b/packages/collections/web-test-runner.config.js
@@ -0,0 +1,13 @@
+/*
+ * Copyright (c) Jupyter Development Team.
+ * Distributed under the terms of the Modified BSD License.
+ */
+
+module.exports = {
+  testFramework: {
+    config: {
+      forbidOnly: process.env.CI ? true : false,
+      forbidPending: process.env.CI ? true : false
+    }
+  }
+};
diff --git a/packages/commands/web-test-runner.config.js b/packages/commands/web-test-runner.config.js
@@ -0,0 +1,13 @@
+/*
+ * Copyright (c) Jupyter Development Team.
+ * Distributed under the terms of the Modified BSD License.
+ */
+
+module.exports = {
+  testFramework: {
+    config: {
+      forbidOnly: process.env.CI ? true : false,
+      forbidPending: process.env.CI ? true : false
+    }
+  }
+};
diff --git a/packages/coreutils/web-test-runner.config.js b/packages/coreutils/web-test-runner.config.js
@@ -0,0 +1,13 @@
+/*
+ * Copyright (c) Jupyter Development Team.
+ * Distributed under the terms of the Modified BSD License.
+ */
+
+module.exports = {
+  testFramework: {
+    config: {
+      forbidOnly: process.env.CI ? true : false,
+      forbidPending: process.env.CI ? true : false
+    }
+  }
+};
diff --git a/packages/datagrid/web-test-runner.config.js b/packages/datagrid/web-test-runner.config.js
@@ -0,0 +1,13 @@
+/*
+ * Copyright (c) Jupyter Development Team.
+ * Distributed under the terms of the Modified BSD License.
+ */
+
+module.exports = {
+  testFramework: {
+    config: {
+      forbidOnly: process.env.CI ? true : false,
+      forbidPending: process.env.CI ? true : false
+    }
+  }
+};
diff --git a/packages/default-theme/web-test-runner.config.js b/packages/default-theme/web-test-runner.config.js
@@ -0,0 +1,13 @@
+/*
+ * Copyright (c) Jupyter Development Team.
+ * Distributed under the terms of the Modified BSD License.
+ */
+
+module.exports = {
+  testFramework: {
+    config: {
+      forbidOnly: process.env.CI ? true : false,
+      forbidPending: process.env.CI ? true : false
+    }
+  }
+};
diff --git a/packages/disposable/web-test-runner.config.js b/packages/disposable/web-test-runner.config.js
@@ -0,0 +1,13 @@
+/*
+ * Copyright (c) Jupyter Development Team.
+ * Distributed under the terms of the Modified BSD License.
+ */
+
+module.exports = {
+  testFramework: {
+    config: {
+      forbidOnly: process.env.CI ? true : false,
+      forbidPending: process.env.CI ? true : false
+    }
+  }
+};
diff --git a/packages/domutils/web-test-runner.config.js b/packages/domutils/web-test-runner.config.js
@@ -0,0 +1,13 @@
+/*
+ * Copyright (c) Jupyter Development Team.
+ * Distributed under the terms of the Modified BSD License.
+ */
+
+module.exports = {
+  testFramework: {
+    config: {
+      forbidOnly: process.env.CI ? true : false,
+      forbidPending: process.env.CI ? true : false
+    }
+  }
+};
diff --git a/packages/dragdrop/web-test-runner.config.js b/packages/dragdrop/web-test-runner.config.js
@@ -0,0 +1,13 @@
+/*
+ * Copyright (c) Jupyter Development Team.
+ * Distributed under the terms of the Modified BSD License.
+ */
+
+module.exports = {
+  testFramework: {
+    config: {
+      forbidOnly: process.env.CI ? true : false,
+      forbidPending: process.env.CI ? true : false
+    }
+  }
+};
diff --git a/packages/keyboard/web-test-runner.config.js b/packages/keyboard/web-test-runner.config.js
@@ -0,0 +1,13 @@
+/*
+ * Copyright (c) Jupyter Development Team.
+ * Distributed under the terms of the Modified BSD License.
+ */
+
+module.exports = {
+  testFramework: {
+    config: {
+      forbidOnly: process.env.CI ? true : false,
+      forbidPending: process.env.CI ? true : false
+    }
+  }
+};
diff --git a/packages/messaging/web-test-runner.config.js b/packages/messaging/web-test-runner.config.js
@@ -0,0 +1,13 @@
+/*
+ * Copyright (c) Jupyter Development Team.
+ * Distributed under the terms of the Modified BSD License.
+ */
+
+module.exports = {
+  testFramework: {
+    config: {
+      forbidOnly: process.env.CI ? true : false,
+      forbidPending: process.env.CI ? true : false
+    }
+  }
+};
diff --git a/packages/polling/web-test-runner.config.js b/packages/polling/web-test-runner.config.js
@@ -0,0 +1,13 @@
+/*
+ * Copyright (c) Jupyter Development Team.
+ * Distributed under the terms of the Modified BSD License.
+ */
+
+module.exports = {
+  testFramework: {
+    config: {
+      forbidOnly: process.env.CI ? true : false,
+      forbidPending: process.env.CI ? true : false
+    }
+  }
+};
diff --git a/packages/properties/web-test-runner.config.js b/packages/properties/web-test-runner.config.js
@@ -0,0 +1,13 @@
+/*
+ * Copyright (c) Jupyter Development Team.
+ * Distributed under the terms of the Modified BSD License.
+ */
+
+module.exports = {
+  testFramework: {
+    config: {
+      forbidOnly: process.env.CI ? true : false,
+      forbidPending: process.env.CI ? true : false
+    }
+  }
+};
diff --git a/packages/signaling/web-test-runner.config.js b/packages/signaling/web-test-runner.config.js
@@ -0,0 +1,13 @@
+/*
+ * Copyright (c) Jupyter Development Team.
+ * Distributed under the terms of the Modified BSD License.
+ */
+
+module.exports = {
+  testFramework: {
+    config: {
+      forbidOnly: process.env.CI ? true : false,
+      forbidPending: process.env.CI ? true : false
+    }
+  }
+};
diff --git a/packages/virtualdom/web-test-runner.config.js b/packages/virtualdom/web-test-runner.config.js
@@ -0,0 +1,13 @@
+/*
+ * Copyright (c) Jupyter Development Team.
+ * Distributed under the terms of the Modified BSD License.
+ */
+
+module.exports = {
+  testFramework: {
+    config: {
+      forbidOnly: process.env.CI ? true : false,
+      forbidPending: process.env.CI ? true : false
+    }
+  }
+};
diff --git a/packages/widgets/tests/src/docklayout.spec.ts b/packages/widgets/tests/src/docklayout.spec.ts
@@ -225,24 +225,24 @@ describe('@lumino/widgets', () => {
     });
 
     // TODO: More tests to add
-    describe('#widgets()', () => {
-      it.skip('should have some tests');
-    });
-    describe('#selectedWidgets()', () => {
-      it.skip('should have some tests');
-    });
-    describe('#tabBars()', () => {
-      it.skip('should have some tests');
-    });
-    describe('#moveHandle()', () => {
-      it.skip('should have some tests');
-    });
-    describe('#saveLayout()', () => {
-      it.skip('should have some tests');
-    });
-    describe('#restoreLayout()', () => {
-      it.skip('should have some tests');
-    });
+    // describe('#widgets()', () => {
+    //   it.skip('should have some tests');
+    // });
+    // describe('#selectedWidgets()', () => {
+    //   it.skip('should have some tests');
+    // });
+    // describe('#tabBars()', () => {
+    //   it.skip('should have some tests');
+    // });
+    // describe('#moveHandle()', () => {
+    //   it.skip('should have some tests');
+    // });
+    // describe('#saveLayout()', () => {
+    //   it.skip('should have some tests');
+    // });
+    // describe('#restoreLayout()', () => {
+    //   it.skip('should have some tests');
+    // });
     describe('#addWidget()', () => {
       type Mode = DockLayout.InsertMode;
       it('should add widgets', () => {
@@ -292,17 +292,17 @@ describe('@lumino/widgets', () => {
         }
       });
     });
-    describe('#removeWidget()', () => {
-      it.skip('should have some tests');
-    });
-    describe('#hitTestTabAreas()', () => {
-      it.skip('should have some tests');
-    });
-    describe('#attachWidget()', () => {
-      it.skip('should have some tests');
-    });
-    describe('#detachWidget()', () => {
-      it.skip('should have some tests');
-    });
+    // describe('#removeWidget()', () => {
+    //   it.skip('should have some tests');
+    // });
+    // describe('#hitTestTabAreas()', () => {
+    //   it.skip('should have some tests');
+    // });
+    // describe('#attachWidget()', () => {
+    //   it.skip('should have some tests');
+    // });
+    // describe('#detachWidget()', () => {
+    //   it.skip('should have some tests');
+    // });
   });
 });
diff --git a/packages/widgets/tests/src/menu.spec.ts b/packages/widgets/tests/src/menu.spec.ts
@@ -615,7 +615,7 @@ describe('@lumino/widgets', () => {
         expect(menu.node.style.transform.endsWith('px, 300px)')).to.equal(true);
       });
 
-      it.only('horizontalAlignment should default to `right` if language direction is `rtl`', () => {
+      it('horizontalAlignment should default to `right` if language direction is `rtl`', () => {
         document.documentElement.setAttribute('dir', 'rtl');
         menu.addItem({ command: 'test' });
         menu.open(300, 300);
diff --git a/packages/widgets/web-test-runner.config.js b/packages/widgets/web-test-runner.config.js
@@ -0,0 +1,13 @@
+/*
+ * Copyright (c) Jupyter Development Team.
+ * Distributed under the terms of the Modified BSD License.
+ */
+
+module.exports = {
+  testFramework: {
+    config: {
+      forbidOnly: process.env.CI ? true : false,
+      forbidPending: process.env.CI ? true : false
+    }
+  }
+};
