Skip to content

Commit d4a2ccf

Browse files
committed
"npm run" -> yarn
If we are using yarn, then it should be everywhere. Without this, binary resolution fails on Windows.
1 parent 3686229 commit d4a2ccf

File tree

18 files changed

+119
-119
lines changed

18 files changed

+119
-119
lines changed

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ jobs:
144144
data = json.load(f)
145145
146146
data["version"] = datetime.now().strftime("%Y.%m.%d")
147-
data["jupyter-releaser"] = { "options": { "version-cmd": "npm run update:versions -- --yes" } }
147+
data["jupyter-releaser"] = { "options": { "version-cmd": "yarn update:versions -- --yes" } }
148148
149149
with open("package.json", "w") as f:
150150
data = json.dump(data, f)

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
],
1010
"scripts": {
1111
"api": "lerna run api",
12-
"build": "npm run build:src",
13-
"build:dist": "npm run build && npm run minimize",
12+
"build": "yarn build:src",
13+
"build:dist": "yarn build && yarn minimize",
1414
"build:examples": "lerna run build --scope \"@lumino/example-*\" --concurrency 1",
1515
"build:src": "lerna run build --scope \"@lumino/!(test-|example-)*\" --concurrency 1",
1616
"build:test": "lerna run build:test",
@@ -29,7 +29,7 @@
2929
"minimize": "lerna run minimize",
3030
"prettier": "prettier --write \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}\"",
3131
"prettier:check": "prettier --check \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}\"",
32-
"publish": "npm run clean && npm run build:dist && node scripts/tag-versions.js && lerna publish --yes -m \"Publish\" from-package",
32+
"publish": "yarn clean && yarn build:dist && node scripts/tag-versions.js && lerna publish --yes -m \"Publish\" from-package",
3333
"remove:dependency": "remove-dependency",
3434
"test": "lerna run test --concurrency 1 --no-bail --scope \"@lumino/!(example-)*\"",
3535
"test:chromium": "lerna run test:chromium --no-bail --concurrency 1",

packages/algorithm/package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,17 @@
2424
],
2525
"scripts": {
2626
"api": "api-extractor run --local --verbose",
27-
"build": "npm run build:src && rollup -c",
27+
"build": "yarn build:src && rollup -c",
2828
"build:src": "tsc --build",
29-
"build:test": "npm run clean:test && tsc --build tests && cd tests && rollup -c",
29+
"build:test": "yarn clean:test && tsc --build tests && cd tests && rollup -c",
3030
"clean": "rimraf ./lib *.tsbuildinfo ./types ./dist",
3131
"clean:test": "rimraf tests/lib tests/tsconfig.tsbuildinfo",
3232
"minimize": "terser dist/index.js -c -m --source-map \"content='dist/index.js.map',url='index.min.js.map'\" -o dist/index.min.js",
33-
"test": "npm run build:test && web-test-runner tests/lib/bundle.test.js --node-resolve --playwright",
34-
"test:debug": "npm run test -- --manual --open",
35-
"test:chromium": "npm run test -- --browsers chromium",
36-
"test:firefox": "npm run test -- --browsers firefox",
37-
"test:webkit": "npm run test -- --browsers webkit",
33+
"test": "yarn build:test && web-test-runner tests/lib/bundle.test.js --node-resolve --playwright",
34+
"test:chromium": "yarn test -- --browsers chromium",
35+
"test:debug": "yarn test -- --manual --open",
36+
"test:firefox": "yarn test -- --browsers firefox",
37+
"test:webkit": "yarn test -- --browsers webkit",
3838
"watch": "tsc --build --watch"
3939
},
4040
"devDependencies": {

packages/application/package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,17 @@
2424
],
2525
"scripts": {
2626
"api": "api-extractor run --local --verbose",
27-
"build": "npm run build:src && rollup -c",
27+
"build": "yarn build:src && rollup -c",
2828
"build:src": "tsc --build",
29-
"build:test": "npm run clean:test && tsc --build tests && cd tests && rollup -c",
29+
"build:test": "yarn clean:test && tsc --build tests && cd tests && rollup -c",
3030
"clean": "rimraf ./lib *.tsbuildinfo ./types ./dist",
3131
"clean:test": "rimraf tests/lib tests/tsconfig.tsbuildinfo",
3232
"minimize": "terser dist/index.js -c -m --source-map \"content='dist/index.js.map',url='index.min.js.map'\" -o dist/index.min.js",
33-
"test": "npm run build:test && web-test-runner tests/lib/bundle.test.js --node-resolve --playwright",
34-
"test:debug": "npm run test -- --manual --open",
35-
"test:chromium": "npm run test -- --browsers chromium",
36-
"test:firefox": "npm run test -- --browsers firefox",
37-
"test:webkit": "npm run test -- --browsers webkit",
33+
"test": "yarn build:test && web-test-runner tests/lib/bundle.test.js --node-resolve --playwright",
34+
"test:chromium": "yarn test -- --browsers chromium",
35+
"test:debug": "yarn test -- --manual --open",
36+
"test:firefox": "yarn test -- --browsers firefox",
37+
"test:webkit": "yarn test -- --browsers webkit",
3838
"watch": "tsc --build --watch"
3939
},
4040
"dependencies": {

packages/collections/package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,17 @@
2424
],
2525
"scripts": {
2626
"api": "api-extractor run --local --verbose",
27-
"build": "npm run build:src && rollup -c",
27+
"build": "yarn build:src && rollup -c",
2828
"build:src": "tsc --build",
29-
"build:test": "npm run clean:test && tsc --build tests && cd tests && rollup -c",
29+
"build:test": "yarn clean:test && tsc --build tests && cd tests && rollup -c",
3030
"clean": "rimraf ./lib *.tsbuildinfo ./types ./dist",
3131
"clean:test": "rimraf tests/lib tests/tsconfig.tsbuildinfo",
3232
"minimize": "terser dist/index.js -c -m --source-map \"content='dist/index.js.map',url='index.min.js.map'\" -o dist/index.min.js",
33-
"test": "npm run build:test && web-test-runner tests/lib/bundle.test.js --node-resolve --playwright",
34-
"test:debug": "npm run test -- --manual --open",
35-
"test:chromium": "npm run test -- --browsers chromium",
36-
"test:firefox": "npm run test -- --browsers firefox",
37-
"test:webkit": "npm run test -- --browsers webkit",
33+
"test": "yarn build:test && web-test-runner tests/lib/bundle.test.js --node-resolve --playwright",
34+
"test:chromium": "yarn test -- --browsers chromium",
35+
"test:debug": "yarn test -- --manual --open",
36+
"test:firefox": "yarn test -- --browsers firefox",
37+
"test:webkit": "yarn test -- --browsers webkit",
3838
"watch": "tsc --build --watch"
3939
},
4040
"dependencies": {

packages/commands/package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,17 @@
2424
],
2525
"scripts": {
2626
"api": "api-extractor run --local --verbose",
27-
"build": "npm run build:src && rollup -c",
27+
"build": "yarn build:src && rollup -c",
2828
"build:src": "tsc --build",
29-
"build:test": "npm run clean:test && tsc --build tests && cd tests && rollup -c",
29+
"build:test": "yarn clean:test && tsc --build tests && cd tests && rollup -c",
3030
"clean": "rimraf ./lib *.tsbuildinfo ./types ./dist",
3131
"clean:test": "rimraf tests/lib tests/tsconfig.tsbuildinfo",
3232
"minimize": "terser dist/index.js -c -m --source-map \"content='dist/index.js.map',url='index.min.js.map'\" -o dist/index.min.js",
33-
"test": "npm run build:test && web-test-runner tests/lib/bundle.test.js --node-resolve --playwright",
34-
"test:debug": "npm run test -- --manual --open",
35-
"test:chromium": "npm run test -- --browsers chromium",
36-
"test:firefox": "npm run test -- --browsers firefox",
37-
"test:webkit": "npm run test -- --browsers webkit",
33+
"test": "yarn build:test && web-test-runner tests/lib/bundle.test.js --node-resolve --playwright",
34+
"test:chromium": "yarn test -- --browsers chromium",
35+
"test:debug": "yarn test -- --manual --open",
36+
"test:firefox": "yarn test -- --browsers firefox",
37+
"test:webkit": "yarn test -- --browsers webkit",
3838
"watch": "tsc --build --watch"
3939
},
4040
"dependencies": {

packages/coreutils/package.json

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,10 @@
1313
"license": "BSD-3-Clause",
1414
"author": "Project Jupyter",
1515
"main": "dist/index.node.js",
16-
"browser": "dist/index.js",
1716
"jsdelivr": "dist/index.min.js",
1817
"unpkg": "dist/index.min.js",
1918
"module": "dist/index.es6",
20-
"module-node": "dist/index.node.es6",
19+
"browser": "dist/index.js",
2120
"types": "types/index.d.ts",
2221
"files": [
2322
"dist/*",
@@ -26,17 +25,17 @@
2625
],
2726
"scripts": {
2827
"api": "api-extractor run --local --verbose",
29-
"build": "npm run build:src && rollup -c",
28+
"build": "yarn build:src && rollup -c",
3029
"build:src": "tsc --build",
31-
"build:test": "npm run clean:test && tsc --build tests && cd tests && rollup -c",
30+
"build:test": "yarn clean:test && tsc --build tests && cd tests && rollup -c",
3231
"clean": "rimraf ./lib *.tsbuildinfo ./types ./dist",
3332
"clean:test": "rimraf tests/lib tests/tsconfig.tsbuildinfo",
3433
"minimize": "terser dist/index.js -c -m --source-map \"content='dist/index.js.map',url='index.min.js.map'\" -o dist/index.min.js",
35-
"test": "npm run build:test && web-test-runner tests/lib/bundle.test.js --node-resolve --playwright",
36-
"test:debug": "npm run test -- --manual --open",
37-
"test:chromium": "npm run test -- --browsers chromium",
38-
"test:firefox": "npm run test -- --browsers firefox",
39-
"test:webkit": "npm run test -- --browsers webkit",
34+
"test": "yarn build:test && web-test-runner tests/lib/bundle.test.js --node-resolve --playwright",
35+
"test:chromium": "yarn test -- --browsers chromium",
36+
"test:debug": "yarn test -- --manual --open",
37+
"test:firefox": "yarn test -- --browsers firefox",
38+
"test:webkit": "yarn test -- --browsers webkit",
4039
"watch": "tsc --build --watch"
4140
},
4241
"dependencies": {
@@ -64,5 +63,6 @@
6463
},
6564
"publishConfig": {
6665
"access": "public"
67-
}
66+
},
67+
"module-node": "dist/index.node.es6"
6868
}

packages/datagrid/package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,17 @@
2424
],
2525
"scripts": {
2626
"api": "api-extractor run --local --verbose",
27-
"build": "npm run build:src && rollup -c",
27+
"build": "yarn build:src && rollup -c",
2828
"build:src": "tsc --build",
29-
"build:test": "npm run clean:test && tsc --build tests && cd tests && rollup -c",
29+
"build:test": "yarn clean:test && tsc --build tests && cd tests && rollup -c",
3030
"clean": "rimraf ./lib *.tsbuildinfo ./types ./dist",
3131
"clean:test": "rimraf tests/lib tests/tsconfig.tsbuildinfo",
3232
"minimize": "terser dist/index.js -c -m --source-map \"content='dist/index.js.map',url='index.min.js.map'\" -o dist/index.min.js",
33-
"test": "npm run build:test && web-test-runner tests/lib/bundle.test.js --node-resolve --playwright",
34-
"test:debug": "npm run test -- --manual --open",
35-
"test:chromium": "npm run test -- --browsers chromium",
36-
"test:firefox": "npm run test -- --browsers firefox",
37-
"test:webkit": "npm run test -- --browsers webkit",
33+
"test": "yarn build:test && web-test-runner tests/lib/bundle.test.js --node-resolve --playwright",
34+
"test:chromium": "yarn test -- --browsers chromium",
35+
"test:debug": "yarn test -- --manual --open",
36+
"test:firefox": "yarn test -- --browsers firefox",
37+
"test:webkit": "yarn test -- --browsers webkit",
3838
"watch": "tsc --build --watch"
3939
},
4040
"dependencies": {

packages/disposable/package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,17 @@
2424
],
2525
"scripts": {
2626
"api": "api-extractor run --local --verbose",
27-
"build": "npm run build:src && rollup -c",
27+
"build": "yarn build:src && rollup -c",
2828
"build:src": "tsc --build",
29-
"build:test": "npm run clean:test && tsc --build tests && cd tests && rollup -c",
29+
"build:test": "yarn clean:test && tsc --build tests && cd tests && rollup -c",
3030
"clean": "rimraf ./lib *.tsbuildinfo ./types ./dist",
3131
"clean:test": "rimraf tests/lib tests/tsconfig.tsbuildinfo",
3232
"minimize": "terser dist/index.js -c -m --source-map \"content='dist/index.js.map',url='index.min.js.map'\" -o dist/index.min.js",
33-
"test": "npm run build:test && web-test-runner tests/lib/bundle.test.js --node-resolve --playwright",
34-
"test:debug": "npm run test -- --manual --open",
35-
"test:chromium": "npm run test -- --browsers chromium",
36-
"test:firefox": "npm run test -- --browsers firefox",
37-
"test:webkit": "npm run test -- --browsers webkit",
33+
"test": "yarn build:test && web-test-runner tests/lib/bundle.test.js --node-resolve --playwright",
34+
"test:chromium": "yarn test -- --browsers chromium",
35+
"test:debug": "yarn test -- --manual --open",
36+
"test:firefox": "yarn test -- --browsers firefox",
37+
"test:webkit": "yarn test -- --browsers webkit",
3838
"watch": "tsc --build --watch"
3939
},
4040
"dependencies": {

packages/domutils/package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,17 @@
2424
],
2525
"scripts": {
2626
"api": "api-extractor run --local --verbose",
27-
"build": "npm run build:src && rollup -c",
27+
"build": "yarn build:src && rollup -c",
2828
"build:src": "tsc --build",
29-
"build:test": "npm run clean:test && tsc --build tests && cd tests && rollup -c",
29+
"build:test": "yarn clean:test && tsc --build tests && cd tests && rollup -c",
3030
"clean": "rimraf ./lib *.tsbuildinfo ./types ./dist",
3131
"clean:test": "rimraf tests/lib tests/tsconfig.tsbuildinfo",
3232
"minimize": "terser dist/index.js -c -m --source-map \"content='dist/index.js.map',url='index.min.js.map'\" -o dist/index.min.js",
33-
"test": "npm run build:test && web-test-runner tests/lib/bundle.test.js --node-resolve --playwright",
34-
"test:debug": "npm run test -- --manual --open",
35-
"test:chromium": "npm run test -- --browsers chromium",
36-
"test:firefox": "npm run test -- --browsers firefox",
37-
"test:webkit": "npm run test -- --browsers webkit",
33+
"test": "yarn build:test && web-test-runner tests/lib/bundle.test.js --node-resolve --playwright",
34+
"test:chromium": "yarn test -- --browsers chromium",
35+
"test:debug": "yarn test -- --manual --open",
36+
"test:firefox": "yarn test -- --browsers firefox",
37+
"test:webkit": "yarn test -- --browsers webkit",
3838
"watch": "tsc --build --watch"
3939
},
4040
"devDependencies": {

0 commit comments

Comments
 (0)