more style fixes

Author: jtpio

packages/javascript-kernel/src/executor.ts

@@ -695,7 +695,7 @@ export class JavaScriptExecutor {
       };
     } catch {
       // Try to provide info even if we can't evaluate
-      return this._inspectBuiltin(expression, detailLevel);
+      return this.inspectBuiltin(expression, detailLevel);
     }
   }
 
@@ -707,7 +707,7 @@ export class JavaScriptExecutor {
    * @param detailLevel - The level of detail requested.
    * @returns The inspection result.
    */
-  protected _inspectBuiltin(
+  protected inspectBuiltin(
     expression: string,
     detailLevel: number
   ): IInspectResult {
@@ -718,7 +718,7 @@ export class JavaScriptExecutor {
     }
 
     // Fall back to predefined documentation
-    const doc = this._getBuiltinDocumentation(expression);
+    const doc = this.getBuiltinDocumentation(expression);
     if (doc) {
       return {
         found: true,
@@ -757,7 +757,7 @@ export class JavaScriptExecutor {
    * @param expression - The expression to get documentation for.
    * @returns The documentation string, or null if not found.
    */
-  protected _getBuiltinDocumentation(expression: string): string | null {
+  protected getBuiltinDocumentation(expression: string): string | null {
     // Common JavaScript built-ins documentation
     const builtins: Record<string, string> = {
       console:
@@ -1544,7 +1544,7 @@ export class JavaScriptExecutor {
       );
 
       // Add predefined documentation if available
-      const doc = this._getBuiltinDocumentation(expression);
+      const doc = this.getBuiltinDocumentation(expression);
       if (doc) {
         const mdContent = inspectionData['text/markdown'] || '';
         inspectionData['text/markdown'] = mdContent + `\n\n---\n\n${doc}`;

packages/javascript-kernel/src/kernel.ts

@@ -20,7 +20,7 @@ export class JavaScriptKernel extends BaseKernel implements IKernel {
    */
   constructor(options: JavaScriptKernel.IOptions) {
     super(options);
-    this._initIFrame();
+    this.initIFrame();
   }
 
   /**
@@ -30,7 +30,7 @@ export class JavaScriptKernel extends BaseKernel implements IKernel {
     if (this.isDisposed) {
       return;
     }
-    this._cleanupIFrame();
+    this.cleanupIFrame();
     super.dispose();
   }
 
@@ -306,14 +306,14 @@ export class JavaScriptKernel extends BaseKernel implements IKernel {
    *
    * @param code - The code to execute.
    */
-  protected _eval(code: string): any {
+  protected evaluate(code: string): any {
     return this._evalCodeFunc(this._iframe.contentWindow, code);
   }
 
   /**
    * Initialize the IFrame and set up communication.
    */
-  protected async _initIFrame(): Promise<void> {
+  protected async initIFrame(): Promise<void> {
     this._container = document.createElement('div');
     this._container.style.cssText =
       'position:absolute;width:0;height:0;overflow:hidden;';
@@ -341,20 +341,20 @@ export class JavaScriptKernel extends BaseKernel implements IKernel {
     });
 
     // Set up console overrides in the iframe
-    this._setupConsoleOverrides();
+    this.setupConsoleOverrides();
 
     // Set up message handling for console output
     this._messageHandler = (event: MessageEvent) => {
       if (event.source === this._iframe.contentWindow) {
-        this._processMessage(event.data);
+        this.processMessage(event.data);
       }
     };
     window.addEventListener('message', this._messageHandler);
 
     // Initialize the executor with the iframe's window
     if (this._iframe.contentWindow) {
       this._executor = new JavaScriptExecutor(this._iframe.contentWindow);
-      this._setupDisplay();
+      this.setupDisplay();
     }
 
     this._ready.resolve();
@@ -363,7 +363,7 @@ export class JavaScriptKernel extends BaseKernel implements IKernel {
   /**
    * Set up the display() function in the iframe.
    */
-  protected _setupDisplay(): void {
+  protected setupDisplay(): void {
     if (!this._iframe.contentWindow || !this._executor) {
       return;
     }
@@ -387,7 +387,7 @@ export class JavaScriptKernel extends BaseKernel implements IKernel {
   /**
    * Set up console overrides in the iframe to bubble output to parent.
    */
-  protected _setupConsoleOverrides(): void {
+  protected setupConsoleOverrides(): void {
     if (!this._iframe.contentWindow) {
       return;
     }
@@ -426,7 +426,7 @@ export class JavaScriptKernel extends BaseKernel implements IKernel {
   /**
    * Clean up the iframe resources.
    */
-  protected _cleanupIFrame(): void {
+  protected cleanupIFrame(): void {
     if (this._messageHandler) {
       window.removeEventListener('message', this._messageHandler);
       this._messageHandler = null;
@@ -443,7 +443,7 @@ export class JavaScriptKernel extends BaseKernel implements IKernel {
    *
    * @param msg - The message to process.
    */
-  protected _processMessage(msg: any): void {
+  protected processMessage(msg: any): void {
     if (!msg || !msg.type) {
       return;
     }