Fix search params (#109)

* Fix the default value when there is no search parameters option

* Fix the starting slash in the iframeUrl

* Fix search params not set

* Do not use the baseURL to generate the iframeSrc, to avoid error if iframeSrc start with '../'

* Avoid duplicating the parameters

Author: brichet

jupyterlite_sphinx/jupyterlite_sphinx.js

@@ -33,5 +33,9 @@ window.jupyterliteConcatSearchParams = (iframeSrc, params) => {
     }
   });
 
-  return iframeUrl.toString().replace(baseURL, '');
+  if (iframeUrl.searchParams.size) {
+    return `${iframeSrc.split('?')[0]}?${iframeUrl.searchParams.toString()}`;
+  } else {
+    return iframeSrc;
+  }
 }

jupyterlite_sphinx/jupyterlite_sphinx.py

@@ -52,7 +52,7 @@ def __init__(
         height="100%",
         prompt=False,
         prompt_color=None,
-        search_params=[],
+        search_params="false",
         **attributes,
     ):
         super().__init__(
@@ -221,7 +221,7 @@ def run(self):
         prompt = self.options.pop("prompt", False)
         prompt_color = self.options.pop("prompt_color", None)
 
-        search_params = search_params_parser(self.options.pop("search_params", ""))
+        search_params = search_params_parser(self.options.pop("search_params", False))
 
         prefix = os.path.relpath(
             os.path.join(self.env.app.srcdir, JUPYTERLITE_DIR),
@@ -262,7 +262,7 @@ def run(self):
         prompt = self.options.pop("prompt", False)
         prompt_color = self.options.pop("prompt_color", None)
 
-        search_params = search_params_parser(self.options.pop("search_params", ""))
+        search_params = search_params_parser(self.options.pop("search_params", False))
 
         source_location = os.path.dirname(self.get_source_info()[0])
 
@@ -504,7 +504,7 @@ def setup(app):
 def search_params_parser(search_params: str) -> str:
     pattern = re.compile(r"^\[(?:\s*[\"']{1}([^=\s\,&=\?\/]+)[\"']{1}\s*\,?)+\]$")
     if not search_params:
-        return ""
+        return "false"
     if search_params in ["True", "False"]:
         return search_params.lower()
     elif pattern.match(search_params):