Preserve file extension for unique filenames

[juntyr]

When a file is uploaded and has a name clash, a unique filename must be chosen. The current method appends the increment after the pathname, which interferes with the file extension, e.g. README.md becomes README.md_0. (Since the contents API uses the extension to determine how to interpret the file, this causes plain text files to be displayed as base64 encoded). The new variant puts the disambiguator in front to preserve the extension.

[github-actions]

👈 Launch a Binder on branch juntyr/litegitpuller/patch-1

[jtpio]

Thanks @juntyr for catching this!

It looks like the current implementation would then create a file named 0_README.md?

Wondering if it should be named README_0.md instead, so the files are still next to each others when sorted by name?

[juntyr]

Thanks @juntyr for catching this!

It looks like the current implementation would then create a file named 0_README.md?

Wondering if it should be named README_0.md instead, so the files are still next to each others when sorted by name?

The file will be renamed once the upload of that file is completed anyways, so it will get its original name in the unique upload folder back. But if the name during this upload period matters, then your solution would be nicer.

[juntyr]

I've been thinking a bit more about this. Extensions can meaningfully have one or multiple parts and I think it's really just easier to leave them be entirely, i.e. to not even try to determine where they start and end. Adding a prefix to the filename on upload may look weird for the split-second before the file is moved and renamed to the final location, but it works and fixes an existing bug.

@jtpio Would you be willing to merge this PR and release a patch release for this bug fix?

[jtpio]

Adding a prefix to the filename on upload may look weird for the split-second before the file is moved and renamed to the final location, but it works and fixes an existing bug.

Ah right, if it's just temporary then it's probably fine.

[jtpio]

Thanks!

[jtpio]

Released: https://github.com/jupyterlite/litegitpuller/releases/tag/v0.2.1

[juntyr]

Released: https://github.com/jupyterlite/litegitpuller/releases/tag/v0.2.1

Thank you so much <3

[brichet]

Thanks @juntyr ans @jtpio for this update