Skip to content

Conversation

juntyr
Copy link
Contributor

@juntyr juntyr commented Nov 10, 2024

The docs mention that the urlpath parameter is relative to the repository root (see https://litegitpuller.readthedocs.io/en/latest/index.html#parameters), which is currently not the case.

This PR fixes the code to interpret the urlpath parameter relative to the repository root, which is a breaking change. This behaviour is useful when the repo is not uploaded to a statically known path, e.g. by (in the future) uploading it to the currently opened working directory.

While we theoretically could detect paths starting with tree/ to get back the original behaviour, this would clash with folders named tree inside the repository. Opening a path outside the repo is still possible by giving an absolute path, e.g. /README.md (since absolute paths come out of a join unchanged and JupyterLab strips the leading slash).

Copy link

Binder 👈 Launch a Binder on branch juntyr/litegitpuller/relative-filepath

@juntyr
Copy link
Contributor Author

juntyr commented Nov 10, 2024

Check release failure is caused by pypa/hatch#1793

@juntyr
Copy link
Contributor Author

juntyr commented Nov 11, 2024

Check release failure is caused by pypa/hatch#1793

This has now been fixed

@juntyr juntyr closed this Nov 11, 2024
@juntyr
Copy link
Contributor Author

juntyr commented Nov 11, 2024

Whoops

@juntyr juntyr reopened this Nov 11, 2024
@brichet brichet added the bug Something isn't working label Nov 12, 2024
@brichet
Copy link
Collaborator

brichet commented Nov 12, 2024

Thanks @juntyr for opening this.

The error in check-release does not seem to be related to pypa/hatch#1793 any more.

I can reproduce it locally by running jupyter-releaser prep-git --username juntyr --repo jupyterlite/litegitpuller --branch main --ref refs/pull/22/merge from the root of the repo. The same command seems to work on other repo/PR (after changing the parameters).

@jtpio do you have a clue on this error ?

@jtpio
Copy link
Member

jtpio commented Nov 12, 2024

Strange. We've seen that error before on another repo (jupyter-collaboration?), and recreating a new PR helped fix it I think.

But if it keeps happening we should investigate more, as it may be an issue with the releaser.

@brichet
Copy link
Collaborator

brichet commented Nov 12, 2024

Right, it was jupyterlab/jupyter-collaboration#378

Opening a new PR fixed the error

@juntyr
Copy link
Contributor Author

juntyr commented Nov 12, 2024

Should I close this PR and open a fresh one?

@brichet
Copy link
Collaborator

brichet commented Nov 12, 2024

Should I close this PR and open a fresh one?

yes, we can try that.

@brichet
Copy link
Collaborator

brichet commented Nov 12, 2024

But if it keeps happening we should investigate more, as it may be an issue with the releaser.

The extension template has a concurrency part in the workflow file (but not this extension neither jupyter-collaboration) . I don't know if it can be related...

@jtpio
Copy link
Member

jtpio commented Nov 12, 2024

The extension template has a concurrency part in the workflow file (but not this extension neither jupyter-collaboration) . I don't know if it can be related...

Maybe we can open an issue on the releaser repo to have a look at some point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants