Skip to content

Commit 9000fe2

Browse files
committed
Add fallback for kernel constructor when argv is not accepted
1 parent 7baf8e4 commit 9000fe2

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

packages/xeus/src/worker.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -208,9 +208,11 @@ export abstract class XeusRemoteKernel {
208208

209209
this._initializeStdin(baseUrl, browsingContextId);
210210
// backward compatibility: Checking if the kernel constructor takes argument or not
211-
rawXKernel = globalThis.Module.xkernel.length
212-
? new globalThis.Module.xkernel(kernelSpec.argv)
213-
: new globalThis.Module.xkernel();
211+
try {
212+
rawXKernel = new globalThis.Module.xkernel(kernelSpec.argv);
213+
} catch(e) {
214+
rawXKernel = new globalThis.Module.xkernel();
215+
}
214216
rawXServer = rawXKernel.get_server();
215217
if (!rawXServer) {
216218
this._logger.error('Failed to start kernel!');

0 commit comments

Comments
 (0)