Micromamba dependency and proper prefix relocation (#200)

* Always assume micromamba

* Prefix relocation using micromamba

* Fixup

* Without relocation for now

* Relocate prefix

* Try

* Try

* Fix

Author: martinRenou

.github/workflows/build.yml

@@ -87,62 +87,7 @@ jobs:
         jupyter labextension list 2>&1 | grep -ie "@jupyterlite/xeus.*OK"
         python -m jupyterlab.browser_check --no-browser-test
 
-  python-tests-mamba-python:
-    needs: build
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-
-      - uses: actions/download-artifact@v4
-        with:
-          name: extension-artifacts
-
-      - name: Install Conda environment with Micromamba
-        uses: mamba-org/setup-micromamba@v2
-        with:
-          environment-file: environment-dev.yaml
-
-      - name: Make sure the Mamba Python API is available
-        run: |
-          python -c "from mamba.api import create"
-
-      - name: Install
-        run: pip install jupyterlite_xeus*.whl
-
-      - name: Run tests
-        run: pytest -rP test_xeus.py
-        working-directory: tests
-
-  python-tests-mamba:
-    needs: build
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-
-      - uses: actions/download-artifact@v4
-        with:
-          name: extension-artifacts
-
-      - name: Install Conda environment with Micromamba
-        uses: mamba-org/setup-micromamba@v2
-        with:
-          environment-file: environment-dev.yaml
-
-      - name: Install mamba
-        run: conda install -c conda-forge mamba
-
-      - name: Install
-        run: pip install jupyterlite_xeus*.whl
-
-      - name: Run tests
-        run: pytest -rP test_xeus.py
-        working-directory: tests
-
-  python-tests-micromamba:
+  python-tests:
     needs: build
     runs-on: ubuntu-latest
 
@@ -167,30 +112,6 @@ jobs:
         run: pytest -rP test_xeus.py
         working-directory: tests
 
-  python-tests-conda:
-    needs: build
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-
-      - uses: actions/download-artifact@v4
-        with:
-          name: extension-artifacts
-
-      - name: Install Conda environment with Micromamba
-        uses: mamba-org/setup-micromamba@v2
-        with:
-          environment-file: environment-dev.yaml
-
-      - name: Install
-        run: pip install jupyterlite_xeus*.whl
-
-      - name: Run tests
-        run: pytest -rP test_xeus.py
-        working-directory: tests
-
   integration-tests:
     name: Integration tests
     needs: build

jupyterlite_xeus/create_conda_env.py

@@ -6,16 +6,7 @@
 
 from ._pip import _install_pip_dependencies
 
-try:
-    from mamba.api import create as mamba_create
-
-    MAMBA_PYTHON_AVAILABLE = True
-except ImportError:
-    MAMBA_PYTHON_AVAILABLE = False
-
-MAMBA_COMMAND = shutil.which("mamba")
 MICROMAMBA_COMMAND = shutil.which("micromamba")
-CONDA_COMMAND = shutil.which("conda")
 PLATFORM = "emscripten-wasm32"
 
 
@@ -85,76 +76,32 @@ def _create_conda_env_from_specs_impl(env_name, root_prefix, specs, channels):
 
     Path(root_prefix).mkdir(parents=True, exist_ok=True)
 
-    if MAMBA_PYTHON_AVAILABLE:
-        mamba_create(
-            env_name=env_name,
-            base_prefix=root_prefix,
-            specs=specs,
-            channels=channels,
-            target_platform=PLATFORM,
-        )
-        return
-
     channels_args = []
     for channel in channels:
         channels_args.extend(["-c", channel])
 
-    if MICROMAMBA_COMMAND:
-        subprocess_run(
-            [
-                MICROMAMBA_COMMAND,
-                "create",
-                "--yes",
-                "--no-pyc",
-                "--root-prefix",
-                root_prefix,
-                "--name",
-                env_name,
-                f"--platform={PLATFORM}",
-                *channels_args,
-                *specs,
-            ],
-            check=True,
-        )
-        return
-
-    if MAMBA_COMMAND:
-        # Mamba needs the directory to exist already
-        prefix_path.mkdir(parents=True, exist_ok=True)
-        return _create_env_with_config(MAMBA_COMMAND, prefix_path, specs, channels_args)
+    if not MICROMAMBA_COMMAND:
+        raise RuntimeError("""
+            micromamba is needed for creating the emscripten environment.
+            Please install it using conda `conda install micromamba -c conda-forge` or
+            from https://mamba.readthedocs.io/en/latest/installation/micromamba-installation.html
+        """)
 
-    if CONDA_COMMAND:
-        return _create_env_with_config(CONDA_COMMAND, prefix_path, specs, channels_args)
-
-    raise RuntimeError(
-        """Failed to create the virtual environment for xeus-python,
-        please make sure at least mamba, micromamba or conda is installed.
-        """
-    )
-
-
-def _create_env_with_config(conda, prefix_path, specs, channels_args):
-    subprocess_run(
-        [conda, "create", "--yes", "--prefix", prefix_path, *channels_args],
-        check=True,
-    )
-    _create_config(prefix_path)
     subprocess_run(
         [
-            conda,
-            "install",
+            MICROMAMBA_COMMAND,
+            "create",
             "--yes",
+            "--no-pyc",
             "--prefix",
             prefix_path,
+            "--relocate-prefix",
+            "",
+            "--root-prefix",
+            root_prefix,
+            f"--platform={PLATFORM}",
             *channels_args,
             *specs,
         ],
         check=True,
-        env=os.environ.copy(),
     )
-
-
-def _create_config(prefix_path):
-    with open(prefix_path / ".condarc", "w") as fobj:
-        fobj.write(f"subdir: {PLATFORM}")
-    os.environ["CONDARC"] = str(prefix_path / ".condarc")

tests/test_xeus.py

@@ -93,7 +93,7 @@ def test_mount_point():
     ]
 
     for step in addon.post_build(manager):
-            pass
+        pass
 
     outpath = Path(addon.cwd_name) / "packed_env" / "xpython"