Missing throw in case of malformed kernel (#350)

martinRenou · web-flow · commit f440a910617c · 2026-01-21T09:56:27.000+01:00
diff --git a/packages/xeus-core/src/worker.base.ts b/packages/xeus-core/src/worker.base.ts
@@ -212,6 +212,7 @@ export abstract class XeusRemoteKernelBase {
       this.xserver = this.xkernel.get_server();
       if (!this.xserver) {
         this.logger.error('Failed to start kernel!');
+        throw new Error('Failed to start kernel!');
       }
       this.xkernel.start();
     } catch (e) {

Original file line number	Diff line number	Diff line change
`@@ -212,6 +212,7 @@ export abstract class XeusRemoteKernelBase {`
`212`	`212`	`this.xserver = this.xkernel.get_server();`
`213`	`213`	`if (!this.xserver) {`
`214`	`214`	`this.logger.error('Failed to start kernel!');`
	`215`	`+ throw new Error('Failed to start kernel!');`
`215`	`216`	`}`
`216`	`217`	`this.xkernel.start();`
`217`	`218`	`} catch (e) {`