refactor(frontend): Convert all Leptos component function names to PascalCase (#822)

* refactor(frontend): Convert all Leptos component function names to PascalCase

- Renamed 121 component functions from snake_case to PascalCase
- Improves consistency between function definitions and component usage in JSX
- Makes component functions easier to search and identify
- All component definitions now match their usage in view! macros
- Build verified successfully with no errors

Examples of changes:
- experiment_list -> ExperimentList
- button -> Button
- side_nav -> SideNav
- experiment_form -> ExperimentForm

* feat(lint): Add PascalCase linter for Leptos components

- Created scripts/check_component_names.sh to enforce PascalCase naming
- Integrated linter into `make check` target
- Automatically runs in CI via existing check workflow
- Prevents regression to snake_case component names

The linter scans all Leptos component functions and ensures they use
PascalCase naming convention for consistency with JSX usage.

Also fixed makefile syntax issues:
- Corrected .PHONY declaration format
- Fixed tab/space inconsistency in ifeq block

* fix(lint): Address coderabbit review comments

This commit addresses all coderabbit review feedback:

1. **Fixed sed portability** (scripts/check_component_names.sh:30)
   - Changed `-r` flag to `-E` for BSD/macOS compatibility
   - Extended regex now works on both GNU sed and BSD sed

2. **Renamed all private components to PascalCase** (31 components)
   - webhook_info -> WebhookInfo (pages/webhook.rs:26)
   - info_section -> InfoSection (components/info_modal.rs:4)
   - experiment_group_info -> ExperimentGroupInfo (pages/experiment_groups.rs:6)
   - variable_info -> VariableInfo (pages/variable.rs:20)
   - option and context_options -> Option, ContextOptions (components/context_card.rs:21,38)
   - experiment_info and action components (components/experiment.rs:29,148,181,222,237,242)
   - And 20+ other private components across multiple files

3. **Enhanced linter to check private components**
   - Now enforces PascalCase for both public and private components
   - Fixed false positives on nested helper functions
   - Only matches top-level component function definitions

All changes maintain consistency between component definitions and their
usage in JSX view macros. Build verified successfully.

Resolves all 7 coderabbit nitpick comments on the PR.

* fix: script for checking function names and add auto fix support

---------

Co-authored-by: Claude <[email protected]>
Co-authored-by: [email protected] <[email protected]>

Author: 3 people

crates/frontend/src/app.rs

@@ -30,7 +30,7 @@ use crate::pages::{
 use crate::types::Envs;
 
 #[component]
-pub fn app(app_envs: Envs) -> impl IntoView {
+pub fn App(app_envs: Envs) -> impl IntoView {
     // Provides context that manages stylesheets, titles, meta tags, etc.
     provide_meta_context();
     let service_prefix = app_envs.service_prefix;

crates/frontend/src/bindings/sortable.rs

@@ -116,7 +116,7 @@ impl SortableConfig {
 ///     use leptos::*;
 ///
 ///     #[component]
-///     fn demo_component() -> impl IntoView {
+///     fn DemoComponent() -> impl IntoView {
 ///         Effect::new(move |_| {
 ///             let window = web_sys::window().unwrap();
 ///             let document = window.document().unwrap();

crates/frontend/src/components/alert.rs

@@ -57,7 +57,7 @@ impl AlertType {
 }
 
 #[component]
-pub fn alert(alert: Alert) -> impl IntoView {
+pub fn Alert(alert: Alert) -> impl IntoView {
     let outer_div_class =
         format!("alert max-w-[90vw] {}", alert.alert_type.to_css_class());
     let content_icon = alert.alert_type.to_icon_class();

crates/frontend/src/components/badge.rs

@@ -9,7 +9,7 @@ use crate::components::form::label::Label;
 use super::dropdown::utils::DropdownOption;
 
 #[component]
-pub fn badge<T>(
+pub fn Badge<T>(
     #[prop(into)] options: Signal<Vec<T>>,
     #[prop(into, optional)] handle_remove: Option<Callback<T, ()>>,
     #[prop(into, default = String::new())] class: String,
@@ -57,7 +57,7 @@ where
 }
 
 #[component]
-pub fn gray_pill<T: Display + Clone + 'static>(
+pub fn GrayPill<T: Display + Clone + 'static>(
     #[prop(into)] data: T,
     #[prop(optional_no_strip)] renderer: Option<Callback<T, View>>,
     #[prop(into, default = String::new())] icon_class: String,
@@ -87,7 +87,7 @@ pub fn gray_pill<T: Display + Clone + 'static>(
 }
 
 #[component]
-pub fn list_pills<T>(
+pub fn ListPills<T>(
     #[prop(into)] label: String,
     #[prop(into)] items: Vec<T>,
     #[prop(optional)] pill_renderer: Option<Callback<T, View>>,
@@ -126,7 +126,7 @@ where
 }
 
 #[component]
-pub fn glassy_pills<T: IntoEnumIterator + Display + Eq + Hash + Copy + 'static>(
+pub fn GlassyPills<T: IntoEnumIterator + Display + Eq + Hash + Copy + 'static>(
     #[prop(into)] selected: Signal<Vec<T>>,
     #[prop(into)] title: String,
     #[prop(into)] on_click: Callback<Vec<T>, ()>,

crates/frontend/src/components/button.rs

@@ -10,7 +10,7 @@ pub enum ButtonStyle {
 }
 
 #[component]
-pub fn button(
+pub fn Button(
     #[prop(into)] text: String,
     #[prop(into)] on_click: Callback<MouseEvent, ()>,
     #[prop(into, default = String::new())] class: String,
@@ -61,7 +61,7 @@ pub fn button(
 }
 
 #[component]
-pub fn button_anchor(
+pub fn ButtonAnchor(
     #[prop(into)] text: String,
     #[prop(into)] href: String,
     #[prop(into, default = String::new())] class: String,

crates/frontend/src/components/change_form.rs

@@ -3,7 +3,7 @@ use leptos::*;
 use crate::components::form::label::Label;
 
 #[component]
-pub fn change_form(
+pub fn ChangeForm(
     #[prop(into)] title: String,
     #[prop(into)] placeholder: String,
     #[prop(into, default = String::new())] class: String,

crates/frontend/src/components/change_summary.rs

@@ -81,12 +81,12 @@ pub fn gen_change_table(
 }
 
 #[component]
-fn no_change() -> impl IntoView {
+fn NoChange() -> impl IntoView {
     view! { <div class="text-gray-500 text-center text-sm">"No changes detected."</div> }
 }
 
 #[component]
-pub fn change_summary(
+pub fn ChangeSummary(
     #[prop(into)] title: String,
     #[prop(into, default = "Config Key".to_string())] key_column: String,
     old_values: Map<String, Value>,
@@ -107,7 +107,7 @@ pub fn change_summary(
 }
 
 #[component]
-pub fn json_change_summary(
+pub fn JsonChangeSummary(
     #[prop(into)] title: String,
     old_values: Option<Value>,
     new_values: Option<Value>,
@@ -199,7 +199,7 @@ pub fn json_change_summary(
 }
 
 #[component]
-pub fn change_log_popup(
+pub fn ChangeLogPopup(
     #[prop(into)] title: String,
     #[prop(into)] description: String,
     #[prop(into, default = "Yes".to_string())] confirm_text: String,

crates/frontend/src/components/cohort_schema.rs

@@ -68,7 +68,7 @@ fn validate_cohort_info(enum_name: &str, enum_value: &Value) -> Result<String, S
 }
 
 #[component]
-pub fn cohort_schema(
+pub fn CohortSchema(
     dimension_schema: Value,
     #[prop(into)] on_change: Callback<Value>,
     #[prop(optional)] cohort_based_on: Option<DimensionResponse>,
@@ -405,7 +405,7 @@ enum CohortInputType {
 }
 
 #[component]
-fn cohort_form(
+fn CohortForm(
     #[prop(into, default = String::new())] cohort_name: String,
     value: Value,
     #[prop(into)] on_change: Callback<(String, Value), Result<(), String>>,

crates/frontend/src/components/condition_pills.rs

@@ -29,7 +29,7 @@ pub fn use_condition_collapser() -> WindowListenerHandle {
 }
 
 #[component]
-pub fn condition_expression(
+pub fn ConditionExpression(
     #[prop(into)] id: String,
     #[prop(into)] list_id: String,
     condition: Condition,
@@ -87,7 +87,7 @@ pub fn condition_expression(
 }
 
 #[component]
-pub fn condition(
+pub fn Condition(
     #[prop(into)] id: String,
     #[prop(into)] conditions: Conditions,
     #[prop(into, default=String::new())] class: String,

crates/frontend/src/components/context_card.rs

@@ -16,7 +16,7 @@ use crate::{
 };
 
 #[component]
-fn option(
+fn Option(
     label: String,
     icon: String,
     #[prop(into)] on_click: Callback<(), ()>,
@@ -33,7 +33,7 @@ fn option(
 }
 
 #[component]
-fn context_options(
+fn ContextOptions(
     #[prop(into)] handle_create_experiment: Callback<(), ()>,
     #[prop(into)] handle_delete_experiment: Callback<(), ()>,
     #[prop(into)] handle_clone: Callback<(), ()>,
@@ -82,7 +82,7 @@ fn context_options(
 }
 
 #[component]
-pub fn context_card(
+pub fn ContextCard(
     context: Context,
     overrides: Map<String, Value>,
     #[prop(default = true)] show_actions: bool,