Fixed HOG.groupRectangles return result

Author: plarsson

cc/modules/objdetect/HOGDescriptorBindings.h

@@ -356,8 +356,7 @@ namespace HOGDescriptorBindings {
     }
 
     v8::Local<v8::Value> getReturnValue() {
-      v8::Local<v8::Object> ret = Nan::New<v8::Object>();
-      return ret;
+      return ObjectArrayConverter<Rect, cv::Rect2d, cv::Rect>::wrap(rectList);
     }
 
     bool unwrapRequiredArgs(Nan::NAN_METHOD_ARGS_TYPE info) {

lib/typings/HOGDescriptor.d.ts

@@ -33,8 +33,8 @@ export class HOGDescriptor {
   detectROIAsync(img: Mat, locations: Point2[], hitThreshold?: number, winStride?: Size, padding?: Size): Promise<{ foundLocations: Point2[], confidences: number[] }>;
   getDaimlerPeopleDetector(): number[];
   getDefaultPeopleDetector(): number[];
-  groupRectangles(rectList: Rect[], weights: number[], groupThreshold: number, eps: number): void;
-  groupRectanglesAsync(rectList: Rect[], weights: number[], groupThreshold: number, eps: number): Promise<void>;
+  groupRectangles(rectList: Rect[], weights: number[], groupThreshold: number, eps: number): Rect[];
+  groupRectanglesAsync(rectList: Rect[], weights: number[], groupThreshold: number, eps: number): Promise<Rect[]>;
   load(path: string): void;
   save(path: string): void;
   setSVMDetector(detector: number[]): void;

test/tests/modules/objdetect/HOGDescriptorTests.js

@@ -412,14 +412,14 @@ module.exports = () => {
     });
 
     describe('groupRectangles', () => {
-      const expectOutput = () => {
-        // expect to not throw
+      const expectOutput = (result) => {
+        expect(result).to.be.an('array');
+        result.forEach(rect => expect(rect).instanceOf(cv.Rect));
       };
-
       const rectList = [new cv.Rect(0, 0, 10, 10), new cv.Rect(0, 0, 20, 20)];
       const weights = [0.5, 1.0];
       const groupThreshold = 1;
-      const eps = 0.5;
+      const eps = 2.0;
 
       generateAPITests({
         getDut: () => getTestHOG(),