Pull request feedback from Bob

Author: niekboon

README.md

@@ -50,6 +50,12 @@ return [
 ];
 ```
 
+Or set via environment variable:
+
+```env
+STATAMIC_DETOUR_DRIVER=file
+```
+
 #### Eloquent Driver
 
 Store redirects in the database. This is recommended for larger sites with many redirects for better performance.
@@ -60,6 +66,12 @@ return [
 ];
 ```
 
+Or set via environment variable:
+
+```env
+STATAMIC_DETOUR_DRIVER=eloquent
+```
+
 When using the Eloquent driver, run the migrations:
 
 ```bash

resources/js/components/Detours.vue

@@ -1,38 +1,36 @@
 <template>
     <div>
-        <publish-form :title="''" :action="action" :blueprint="blueprint" :meta="meta" :values="values"
-                      @saved="addItem($event)"></publish-form>
-
+        <publish-form :title="''" :action="action" :blueprint="blueprint" :meta="meta" :values="values" @saved="addItem($event)"></publish-form>
         <table class="min-w-full border border-gray-200">
             <thead class="bg-gray-50">
-            <tr>
-                <th class="px-4 py-3 text-left text-sm font-semibold text-gray-700">{{ __('From') }}</th>
-                <th class="px-4 py-3 text-left text-sm font-semibold text-gray-700">{{ __('To') }}</th>
-                <th class="px-4 py-3 text-left text-sm font-semibold text-gray-700">{{ __('Type') }}</th>
-                <th class="px-4 py-3 text-left text-sm font-semibold text-gray-700">{{ __('Code') }}</th>
-                <th class="px-4 py-3 text-left text-sm font-semibold text-gray-700">{{ __('Sites') }}</th>
-                <th class="px-4 py-3 text-right text-sm font-semibold text-gray-700">{{ __('Delete') }}</th>
-            </tr>
+                <tr>
+                    <th class="px-4 py-3 text-left text-sm font-semibold text-gray-700">{{ __('From') }}</th>
+                    <th class="px-4 py-3 text-left text-sm font-semibold text-gray-700">{{ __('To') }}</th>
+                    <th class="px-4 py-3 text-left text-sm font-semibold text-gray-700">{{ __('Type') }}</th>
+                    <th class="px-4 py-3 text-left text-sm font-semibold text-gray-700">{{ __('Code') }}</th>
+                    <th class="px-4 py-3 text-left text-sm font-semibold text-gray-700">{{ __('Sites') }}</th>
+                    <th class="px-4 py-3 text-right text-sm font-semibold text-gray-700">{{ __('Delete') }}</th>
+                </tr>
             </thead>
             <tbody class="divide-y divide-gray-200">
-            <tr class="hover:bg-gray-50 text-gray-900" v-for="(item, id) in detours" :key="id">
-                <td class="px-4 py-3 text-sm">{{ item.from }}</td>
-                <td class="px-4 py-3 text-sm">{{ item.to }}</td>
-                <td class="px-4 py-3 text-sm">{{ item.type }}</td>
-                <td class="px-4 py-3 text-sm font-medium">{{ item.code }}</td>
-                <td class="px-4 py-3 text-sm space-x-2">
+                <tr class="hover:bg-gray-50 text-gray-900" v-for="(item, id) in detours" :key="id">
+                    <td class="px-4 py-3 text-sm">{{ item.from }}</td>
+                    <td class="px-4 py-3 text-sm">{{ item.to }}</td>
+                    <td class="px-4 py-3 text-sm">{{ item.type }}</td>
+                    <td class="px-4 py-3 text-sm font-medium">{{ item.code }}</td>
+                    <td class="px-4 py-3 text-sm space-x-2">
 
-                    <span class="rounded-full bg-green-500 text-white p-2" v-if="item.sites?.length === 0">{{ __('All') }}</span>
-                    <span class="rounded-full bg-green-500 text-white p-2" v-for="site in item.sites" v-else :key="site">{{ site }}</span>
-                </td>
-                <td class="px-4 py-3 text-right">
-                    <button
-                        @click="deleteDetour(id)"
-                        class="inline-flex items-center px-3 py-1.5 text-sm font-medium text-white bg-red-500 rounded hover:bg-red-400 focus:outline-none focus:ring-2 focus:ring-red-500">
-                        {{ __('Delete') }}
-                    </button>
-                </td>
-            </tr>
+                        <span class="rounded-full bg-green-500 text-white p-2" v-if="item.sites?.length === 0">{{ __('All') }}</span>
+                        <span class="rounded-full bg-green-500 text-white p-2" v-for="site in item.sites" v-else :key="site">{{ site }}</span>
+                    </td>
+                    <td class="px-4 py-3 text-right">
+                        <button
+                            @click="deleteDetour(id)"
+                            class="inline-flex items-center px-3 py-1.5 text-sm font-medium text-white bg-red-500 rounded hover:bg-red-400 focus:outline-none focus:ring-2 focus:ring-red-500">
+                            {{ __('Delete') }}
+                        </button>
+                    </td>
+                </tr>
             </tbody>
         </table>
     </div>

src/Actions/MatchDetour.php

@@ -17,7 +17,7 @@ public function match(string $path): ?Detour
         $repository = $this->resolver->resolve();
 
         /** @var Site $site */
-        $site = SiteFacade::selected();
+        $site = SiteFacade::current();
 
         $detours = $repository->get();