Enhance exit codes for better clarity

Author: justbyitself

cli.js

@@ -1,20 +1,29 @@
 import * as veritaclis from './src/veritaclis.js'
-import * as report from './src/report.js'
+import * as report from './src/report/index.js'
+
+// Exit code constants
+const EXIT_SUCCESS = 0       // All tests passed
+const EXIT_TEST_FAILURE = 1  // One or more tests failed
+const EXIT_ERROR = 2         // Internal error or incorrect usage
 
 if (import.meta.main) {
   const [path] = Deno.args
 
   if (!path) {
     console.error('Please provide a test file or directory path.')
-    Deno.exit(1)
+    Deno.exit(EXIT_ERROR)
   }
 
   try {
-    const result = await veritaclis.run(path)
-    report.viewer(result)
-    Deno.exit(0)
+    const simpleReport = await veritaclis.run(path)
+
+    const analyzedReport = report.analyze(simpleReport)
+
+    report.view(analyzedReport)
+
+    Deno.exit(analyzedReport.allPassed ? EXIT_SUCCESS : EXIT_TEST_FAILURE)
   } catch (error) {
     console.error('Error:', error.message)
-    Deno.exit(1)
+    Deno.exit(EXIT_ERROR)
   }
 }

src/report/analyzer.js

@@ -0,0 +1,58 @@
+export function analyze(simpleReport) {
+  const results = []
+  let totalTests = 0
+  let passedTests = 0
+  let skippedTests = 0
+  let failedTests = 0
+  let errorsCount = 0
+
+  for (const test of simpleReport) {
+    totalTests += 1
+
+    const hasFailedPre = Array.isArray(test.pre)
+      ? test.pre.some(p => !p.passed)
+      : false
+
+    const hasFailedPost = Array.isArray(test.post)
+      ? test.post.some(p => !p.passed)
+      : false
+
+    const hasError = Boolean(test.error)
+
+    const skipped = hasFailedPre
+    const passed = !hasError && !skipped && !hasFailedPost
+
+    if (hasError) {
+      errorsCount += 1
+    }
+
+    if (skipped) {
+      skippedTests += 1
+    } else if (passed) {
+      passedTests += 1
+    } else {
+      failedTests += 1
+    }
+
+    results.push({
+      ...test,
+      passed,
+      skipped,
+    })
+  }
+
+  const allPassed =
+    totalTests > 0 &&
+    passedTests === totalTests &&
+    errorsCount === 0
+
+  return {
+    results,
+    totalTests,
+    passedTests,
+    skippedTests,
+    failedTests,
+    errorsCount,
+    allPassed,
+  }
+}

src/report/index.js

@@ -0,0 +1,2 @@
+export { analyze } from './analyzer.js'
+export { view } from './viewer.js'

src/report.js src/report/viewer.jssrc/report.js renamed to src/report/viewer.js

@@ -1,9 +1,9 @@
 import { green, gray, red, yellow, cyan, bold } from "https://deno.land/std/fmt/colors.ts"
 
-export function viewer(results) {
-  for (const testResult of results) {
+export function view(report) {
+  for (const testResult of report.results) {
     console.log(cyan(bold(testResult.path)))
-    
+
     if (testResult.description) {
       console.log(gray(testResult.description))
     }
@@ -12,7 +12,7 @@ export function viewer(results) {
       console.log(`  PRE: ${pre.description} ... ${pre.passed ? green("OK") : red("FAIL")}`)
     }
 
-    if (testResult.pre.some(p => !p.passed)) {
+    if (testResult.skipped) {
       console.log(yellow("  Test skipped due to failed precondition(s)."))
       console.log()
       continue
@@ -29,7 +29,7 @@ export function viewer(results) {
     console.log()
   }
 
-  const total = results.length
-  const passed = results.filter(r => r.pre.every(p => p.passed) && r.post.every(p => p.passed) && !r.error).length
-  console.log(bold(`Summary: ${passed} / ${total} tests passed.`))
+  const summaryText = `Summary: ${report.passedTests} / ${report.totalTests} tests passed.`
+  const color = report.allPassed ? green : red
+  console.log(color(bold(summaryText)))
 }