Skip to content

Commit 4d59bac

Browse files
committed
Remove failFast from MessageSourceValidationMessage builder
1 parent d3bba94 commit 4d59bac

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+47
-75
lines changed

src/main/java/com/networknt/schema/AdditionalPropertiesValidator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ protected void validate(ExecutionContext executionContext, JsonNode node, JsonNo
120120
executionContext.addError(message().instanceNode(node).property(pname)
121121
.instanceLocation(instanceLocation)
122122
.locale(executionContext.getExecutionConfig().getLocale())
123-
.failFast(executionContext.isFailFast()).arguments(pname).build());
123+
.arguments(pname).build());
124124
} else {
125125
if (additionalPropertiesSchema != null) {
126126
if (!walk) {

src/main/java/com/networknt/schema/AnyOfValidator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ && canShortCircuit() && canShortCircuit(executionContext)) {
122122
}
123123
allErrors.add(message().instanceNode(node).instanceLocation(instanceLocation)
124124
.locale(executionContext.getExecutionConfig().getLocale())
125-
.failFast(executionContext.isFailFast()).arguments(DISCRIMINATOR_REMARK)
125+
.arguments(DISCRIMINATOR_REMARK)
126126
.build());
127127
} else {
128128
// Clear all errors. Note that this is checked in finally.

src/main/java/com/networknt/schema/BaseJsonValidator.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -216,13 +216,10 @@ protected boolean hasAdjacentKeywordInEvaluationPath(String keyword) {
216216
}
217217

218218
protected MessageSourceValidationMessage.Builder message() {
219-
return MessageSourceValidationMessage.builder(this.validationContext.getConfig().getMessageSource(), this.errorMessage, (message, failFast) -> {
220-
if (failFast) {
221-
throw new FailFastAssertionException(message);
222-
}
223-
}).schemaNode(this.schemaNode).schemaLocation(this.schemaLocation)
224-
.evaluationPath(this.evaluationPath).keyword(this.keyword != null ? this.keyword.getValue() : null)
225-
.messageKey(this.getKeyword());
219+
return MessageSourceValidationMessage
220+
.builder(this.validationContext.getConfig().getMessageSource(), this.errorMessage)
221+
.schemaNode(this.schemaNode).schemaLocation(this.schemaLocation).evaluationPath(this.evaluationPath)
222+
.keyword(this.keyword != null ? this.keyword.getValue() : null).messageKey(this.getKeyword());
226223
}
227224

228225
/**

src/main/java/com/networknt/schema/ConstValidator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public void validate(ExecutionContext executionContext, JsonNode node, JsonNode
3737
if (schemaNode.decimalValue().compareTo(node.decimalValue()) != 0) {
3838
executionContext.addError(message().instanceNode(node).instanceLocation(instanceLocation)
3939
.locale(executionContext.getExecutionConfig().getLocale())
40-
.failFast(executionContext.isFailFast()).arguments(schemaNode.asText(), node.asText())
40+
.arguments(schemaNode.asText(), node.asText())
4141
.build());
4242
}
4343
} else if (!schemaNode.equals(node)) {

src/main/java/com/networknt/schema/ContainsValidator.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -116,13 +116,13 @@ public void validate(ExecutionContext executionContext, JsonNode node, JsonNode
116116
if (actual < m) {
117117
boundsViolated(executionContext, isMinV201909 ? ValidatorTypeCode.MIN_CONTAINS : ValidatorTypeCode.CONTAINS,
118118
executionContext.getExecutionConfig().getLocale(),
119-
executionContext.isFailFast(), node, instanceLocation, m);
119+
node, instanceLocation, m);
120120
}
121121

122122
if (this.max != null && actual > this.max) {
123123
boundsViolated(executionContext, isMinV201909 ? ValidatorTypeCode.MAX_CONTAINS : ValidatorTypeCode.CONTAINS,
124124
executionContext.getExecutionConfig().getLocale(),
125-
executionContext.isFailFast(), node, instanceLocation, this.max);
125+
node, instanceLocation, this.max);
126126
}
127127
}
128128

@@ -184,7 +184,7 @@ public void preloadJsonSchema() {
184184
collectAnnotations(); // cache the flag
185185
}
186186

187-
private void boundsViolated(ExecutionContext executionContext, ValidatorTypeCode validatorTypeCode, Locale locale, boolean failFast,
187+
private void boundsViolated(ExecutionContext executionContext, ValidatorTypeCode validatorTypeCode, Locale locale,
188188
JsonNode instanceNode, JsonNodePath instanceLocation, int bounds) {
189189
String messageKey = "contains";
190190
if (ValidatorTypeCode.MIN_CONTAINS.equals(validatorTypeCode)) {
@@ -193,7 +193,7 @@ private void boundsViolated(ExecutionContext executionContext, ValidatorTypeCode
193193
messageKey = CONTAINS_MAX;
194194
}
195195
executionContext.addError(message().instanceNode(instanceNode).instanceLocation(instanceLocation).messageKey(messageKey)
196-
.locale(locale).failFast(failFast).arguments(String.valueOf(bounds), this.schema.getSchemaNode().toString())
196+
.locale(locale).arguments(String.valueOf(bounds), this.schema.getSchemaNode().toString())
197197
.keyword(validatorTypeCode.getValue()).build());
198198
}
199199

src/main/java/com/networknt/schema/ContentEncodingValidator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ public void validate(ExecutionContext executionContext, JsonNode node, JsonNode
8181
if (!matches(node.asText())) {
8282
executionContext.addError(message().instanceNode(node).instanceLocation(instanceLocation)
8383
.locale(executionContext.getExecutionConfig().getLocale())
84-
.failFast(executionContext.isFailFast()).arguments(this.contentEncoding)
84+
.arguments(this.contentEncoding)
8585
.build());
8686
}
8787
}

src/main/java/com/networknt/schema/ContentMediaTypeValidator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ public void validate(ExecutionContext executionContext, JsonNode node, JsonNode
104104
if (!matches(node.asText())) {
105105
executionContext.addError(message().instanceNode(node).instanceLocation(instanceLocation)
106106
.locale(executionContext.getExecutionConfig().getLocale())
107-
.failFast(executionContext.isFailFast()).arguments(this.contentMediaType)
107+
.arguments(this.contentMediaType)
108108
.build());
109109
}
110110
}

src/main/java/com/networknt/schema/DependenciesValidator.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ public void validate(ExecutionContext executionContext, JsonNode node, JsonNode
7373
if (node.get(field) == null) {
7474
executionContext.addError(message().instanceNode(node).property(pname).instanceLocation(instanceLocation)
7575
.locale(executionContext.getExecutionConfig().getLocale())
76-
.failFast(executionContext.isFailFast())
7776
.arguments(propertyDeps.toString()).build());
7877
}
7978
}

src/main/java/com/networknt/schema/DependentRequired.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public void validate(ExecutionContext executionContext, JsonNode node, JsonNode
5757
if (node.get(field) == null) {
5858
executionContext.addError(message().instanceNode(node).property(pname).instanceLocation(instanceLocation)
5959
.locale(executionContext.getExecutionConfig().getLocale())
60-
.failFast(executionContext.isFailFast()).arguments(field, pname)
60+
.arguments(field, pname)
6161
.build());
6262
}
6363
}

src/main/java/com/networknt/schema/EnumValidator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ public void validate(ExecutionContext executionContext, JsonNode node, JsonNode
100100
if (!nodes.contains(node) && !( this.validationContext.getConfig().isTypeLoose() && isTypeLooseContainsInEnum(node))) {
101101
executionContext.addError(message().instanceNode(node).instanceLocation(instanceLocation)
102102
.locale(executionContext.getExecutionConfig().getLocale())
103-
.failFast(executionContext.isFailFast()).arguments(error).build());
103+
.arguments(error).build());
104104
}
105105
}
106106

0 commit comments

Comments
 (0)